Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: components/cronet/android/java/src/org/chromium/net/ResponseInfo.java

Issue 1359343005: Update ResponseInfo to UrlResponseInfo with API review comments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Pass the integration tests. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/ResponseInfo.java
diff --git a/components/cronet/android/java/src/org/chromium/net/ResponseInfo.java b/components/cronet/android/java/src/org/chromium/net/ResponseInfo.java
index 603c080b3d02c37d52eaab0d51fa4727d01e0169..f14f800c6350ae922a3c3047ee65f940c513793e 100644
--- a/components/cronet/android/java/src/org/chromium/net/ResponseInfo.java
+++ b/components/cronet/android/java/src/org/chromium/net/ResponseInfo.java
@@ -4,15 +4,15 @@
package org.chromium.net;
-import android.util.Pair;
-
import java.util.List;
import java.util.Map;
/**
* Contains basic information about a response. Sent to the embedder whenever
* headers are received.
+ * @deprecated Use {@link UrlResponseInfo} instead of this and {@link ExtendedResponseInfo}.
*/
+@Deprecated
public interface ResponseInfo {
/**
* Returns the URL the response is for. This is the URL after following
@@ -26,7 +26,7 @@ public interface ResponseInfo {
* the following entries are redirects followed.
* @return the URL chain.
*/
- String[] getUrlChain();
+ List<String> getUrlChain();
/**
* Returns the HTTP status code. When a resource is retrieved from the cache,
@@ -47,7 +47,7 @@ public interface ResponseInfo {
* The headers are in the same order they are received over the wire.
* @return an unmodifiable list of response header field and value pairs.
*/
- List<Pair<String, String>> getAllHeadersAsList();
+ List<Map.Entry<String, String>> getAllHeadersAsList();
/**
* Returns an unmodifiable map of the response-header fields and values.

Powered by Google App Engine
This is Rietveld 408576698