win_toolchain/toolchain.sha1 - Issue 135933002: Automatic Windows toolchain

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: win_toolchain/toolchain.sha1

Issue 135933002: Automatic Windows toolchain (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: extract whole iso Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 f31aca625a2ebb7f05439641e1c2ce5e23ed1bf9
	M-A Ruel 2014/01/13 18:29:05 Shouldn't this file be named toolchain_vs2013.sha1 Shouldn't this file be named toolchain_vs2013.sha1? Isn't the sha1 different when a user gets the Pro or the Express version? scottmg 2014/01/13 18:46:18 Done. Show quoted text On 2014/01/13 18:29:05, M-A Ruel wrote: > Shouldn't this file be named toolchain_vs2013.sha1? Done. Show quoted text > > Isn't the sha1 different when a user gets the Pro or the Express version? Yes, I haven't tackled that problem yet. I guess it will need to be a pair (or even set) of versions. Currently get_toolchain_if_necessary.py always gets Pro.
OLD	NEW