Infer setter parameter types in strong mode

Infer setter parameter types in strong mode

This change also decouples setters and getters, which matches what DDC currently does. The benefit is they're inferred as independent methods, which allows code reuse between method/getter/setters. It also prevents ordering issues that might occur otherwise (i.e. if getter inference considers setter's type, and setter inference considers the getter's type).

More context: https://github.com/dart-lang/dev_compiler/issues/342#issuecomment-142713453

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/83a2449062a56623919f19f57743fc9b841e7fad

[Jennifer Messerly, 2015-09-24 17:13:38]

jmesserly@google.com changed reviewers:
+ brianwilkerson@google.com, leafp@google.com

[Jennifer Messerly, 2015-09-24 17:15:36]

Note, there's a related issue with generics,
https://github.com/dart-lang/dev_compiler/issues/342#issuecomment-142748853, I'm
working on that in a separate CL

[Brian Wilkerson, 2015-09-24 19:31:51]

LGTM

https://codereview.chromium.org/1359243003/diff/20001/pkg/analyzer/lib/src/ta...
File pkg/analyzer/lib/src/task/strong_mode.dart (right):

https://codereview.chromium.org/1359243003/diff/20001/pkg/analyzer/lib/src/ta...
pkg/analyzer/lib/src/task/strong_mode.dart:320: void
_inferMethod(ExecutableElement element) {
nit: consider renaming to something more generic, such as _inferExecutable

[Jennifer Messerly, 2015-09-24 20:20:44]

https://codereview.chromium.org/1359243003/diff/20001/pkg/analyzer/lib/src/ta...
File pkg/analyzer/lib/src/task/strong_mode.dart (right):

https://codereview.chromium.org/1359243003/diff/20001/pkg/analyzer/lib/src/ta...
pkg/analyzer/lib/src/task/strong_mode.dart:320: void
_inferMethod(ExecutableElement element) {
On 2015/09/24 19:31:51, Brian Wilkerson wrote:
> nit: consider renaming to something more generic, such as _inferExecutable

good idea! done.

[Jennifer Messerly, 2015-09-24 20:21:09]

Committed patchset #3 (id:40001) manually as
83a2449062a56623919f19f57743fc9b841e7fad (presubmit successful).