Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1359233002: Split up JBig2_GeneralDecoder.cpp. (Closed)

Created:
5 years, 3 months ago by Lei Zhang
Modified:
5 years, 3 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : revert bad changes, fix a nit #

Total comments: 2

Patch Set 3 : trick clang-format #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3859 lines, -3551 lines) Patch
M BUILD.gn View 1 2 3 2 chunks +15 lines, -3 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_ArithDecoder.h View 2 chunks +5 lines, -95 lines 0 comments Download
A core/src/fxcodec/jbig2/JBig2_ArithDecoder.cpp View 1 2 1 chunk +166 lines, -0 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_ArithIntDecoder.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
D core/src/fxcodec/jbig2/JBig2_ArithQe.h View 1 chunk +0 lines, -17 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Context.h View 2 chunks +7 lines, -4 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Context.cpp View 1 4 chunks +34 lines, -14 lines 0 comments Download
D core/src/fxcodec/jbig2/JBig2_GeneralDecoder.h View 1 chunk +0 lines, -285 lines 0 comments Download
D core/src/fxcodec/jbig2/JBig2_GeneralDecoder.cpp View 1 chunk +0 lines, -3130 lines 0 comments Download
A core/src/fxcodec/jbig2/JBig2_GrdProc.h View 1 chunk +124 lines, -0 lines 0 comments Download
A core/src/fxcodec/jbig2/JBig2_GrdProc.cpp View 1 chunk +1257 lines, -0 lines 0 comments Download
A core/src/fxcodec/jbig2/JBig2_GrrdProc.h View 1 chunk +44 lines, -0 lines 0 comments Download
A core/src/fxcodec/jbig2/JBig2_GrrdProc.cpp View 1 chunk +515 lines, -0 lines 0 comments Download
A core/src/fxcodec/jbig2/JBig2_GsidProc.h View 1 chunk +36 lines, -0 lines 0 comments Download
A core/src/fxcodec/jbig2/JBig2_GsidProc.cpp View 1 chunk +150 lines, -0 lines 0 comments Download
A core/src/fxcodec/jbig2/JBig2_HtrdProc.h View 1 chunk +47 lines, -0 lines 0 comments Download
A core/src/fxcodec/jbig2/JBig2_HtrdProc.cpp View 1 chunk +103 lines, -0 lines 0 comments Download
A core/src/fxcodec/jbig2/JBig2_PddProc.h View 1 chunk +34 lines, -0 lines 0 comments Download
A core/src/fxcodec/jbig2/JBig2_PddProc.cpp View 1 chunk +86 lines, -0 lines 0 comments Download
A core/src/fxcodec/jbig2/JBig2_SddProc.h View 1 chunk +48 lines, -0 lines 0 comments Download
A core/src/fxcodec/jbig2/JBig2_SddProc.cpp View 1 chunk +651 lines, -0 lines 0 comments Download
A core/src/fxcodec/jbig2/JBig2_TrdProc.h View 1 chunk +83 lines, -0 lines 0 comments Download
A core/src/fxcodec/jbig2/JBig2_TrdProc.cpp View 1 chunk +438 lines, -0 lines 0 comments Download
M pdfium.gyp View 2 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Lei Zhang
One last salute to the general. https://codereview.chromium.org/1359233002/diff/1/core/src/fxcodec/jbig2/JBig2_ArithDecoder.h File core/src/fxcodec/jbig2/JBig2_ArithDecoder.h (left): https://codereview.chromium.org/1359233002/diff/1/core/src/fxcodec/jbig2/JBig2_ArithDecoder.h#oldcode37 core/src/fxcodec/jbig2/JBig2_ArithDecoder.h:37: inline CJBig2_ArithDecoder::CJBig2_ArithDecoder(CJBig2_BitStream* pStream) ...
5 years, 3 months ago (2015-09-23 01:23:29 UTC) #2
Tom Sepez
LGTM, though I'm trusting your ability to copy lines of code unchanged (I didn't match ...
5 years, 3 months ago (2015-09-23 23:03:34 UTC) #3
Lei Zhang
https://codereview.chromium.org/1359233002/diff/20001/core/src/fxcodec/jbig2/JBig2_ArithDecoder.cpp File core/src/fxcodec/jbig2/JBig2_ArithDecoder.cpp (right): https://codereview.chromium.org/1359233002/diff/20001/core/src/fxcodec/jbig2/JBig2_ArithDecoder.cpp#newcode23 core/src/fxcodec/jbig2/JBig2_ArithDecoder.cpp:23: {0x3401, 2, 6, 0}, On 2015/09/23 23:03:34, Tom Sepez ...
5 years, 3 months ago (2015-09-24 08:05:21 UTC) #4
Lei Zhang
5 years, 3 months ago (2015-09-24 08:10:02 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
630a28442364f03c1d3d9b48873da42755e1fddf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698