crosstest/test_calling_conv.h - Issue 1359193003: Subzero. Enables (most) crosstests for ARM32.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: crosstest/test_calling_conv.h

Issue 1359193003: Subzero. Enables (most) crosstests for ARM32. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fixes the broken lit tests. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« crosstest/test_arith_main.cpp ('K') | « crosstest/test_arith_main.cpp ('k') | crosstest/test_calling_conv.cpp » ('j') | pydir/crosstest.py » ('J')

OLD	NEW
1 //===- subzero/crosstest/test_calling_conv.h - Test prototypes --- C++ --===//	1 //===- subzero/crosstest/test_calling_conv.h - Test prototypes --- C++ --===//

2 //	2 //

3 // The Subzero Code Generator	3 // The Subzero Code Generator

4 //	4 //

5 // This file is distributed under the University of Illinois Open Source	5 // This file is distributed under the University of Illinois Open Source

6 // License. See LICENSE.TXT for details.	6 // License. See LICENSE.TXT for details.

7 //	7 //

8 //===----------------------------------------------------------------------===//	8 //===----------------------------------------------------------------------===//

9 //	9 //

10 // This file declares the function prototypes for crosstesting the calling	10 // This file declares the function prototypes for crosstesting the calling

(...skipping 14 matching lines...) Expand all Loading...
25 void caller_alloca_i();	25 void caller_alloca_i();

26 typedef void callee_i_Ty(int);	26 typedef void callee_i_Ty(int);

27 callee_i_Ty callee_i;	27 callee_i_Ty callee_i;

28 callee_i_Ty callee_alloca_i;	28 callee_i_Ty callee_alloca_i;

29	29

30 void caller_vvvvv();	30 void caller_vvvvv();

31 typedef void(callee_vvvvv_Ty)(v4si32, v4si32, v4si32, v4si32, v4si32);	31 typedef void(callee_vvvvv_Ty)(v4si32, v4si32, v4si32, v4si32, v4si32);

32 callee_vvvvv_Ty callee_vvvvv;	32 callee_vvvvv_Ty callee_vvvvv;

33	33

34 void caller_vlvlivfvdviv();	34 void caller_vlvlivfvdviv();

35 typedef void(callee_vlvlivfvdviv_Ty)(v4f32, int64, v4f32, int64, int, v4f32,	35 typedef void(callee_vlvlivfvdviv_Ty)(v4f32, int64, v4f32, int, int64, v4f32,
	Jim Stichnoth 2015/09/24 05:57:13 I'm not sure why you needed to change the argument I'm not sure why you needed to change the argument order, but now the name of the function type doesn't match the arguments. Old: callee_vlvlivfvdviv_Ty New: callee_vlvilvfvdviv_Ty ^^ John 2015/09/24 21:28:39 Done. For reference: The two int64 parameters fit Show quoted text On 2015/09/24 05:57:13, stichnot wrote: > I'm not sure why you needed to change the argument order, but now the name of > the function type doesn't match the arguments. > > Old: callee_vlvlivfvdviv_Ty > New: callee_vlvilvfvdviv_Ty > ^^ Done. For reference: The two int64 parameters fit nicely in r0-r1, and r2-r3. By swapping the arguments I can test that the ARM32 target is passing the second int64 in the stack.
36 float, v4f32, double, v4f32, int, v4f32);	36 float, v4f32, double, v4f32, int, v4f32);

37 callee_vlvlivfvdviv_Ty callee_vlvlivfvdviv;	37 callee_vlvlivfvdviv_Ty callee_vlvlivfvdviv;

OLD	NEW