Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issue 1359113003: Fix GN docs for 'gn help deps' and update reference.md. (Closed)

Created:
5 years, 3 months ago by Dirk Pranke
Modified:
5 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina, Roland McGrath
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GN docs for 'gn help deps' and update reference.md. The help for 'deps' was at best misleading, so we've removed the misleading parts. Also, the reference markdown was out of date, so I've regenerated it. R=brettw@chromium.org BUG= Committed: https://crrev.com/aedcc8a8ea65cb485bafbb4452d29c03e404cd5f Cr-Commit-Position: refs/heads/master@{#350269}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -38 lines) Patch
M tools/gn/docs/reference.md View 24 chunks +108 lines, -34 lines 0 comments Download
M tools/gn/variables.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Dirk Pranke
5 years, 3 months ago (2015-09-22 22:57:11 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359113003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359113003/1
5 years, 3 months ago (2015-09-22 22:58:27 UTC) #3
brettw
lgtm
5 years, 3 months ago (2015-09-22 23:01:20 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-22 23:44:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359113003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359113003/1
5 years, 3 months ago (2015-09-22 23:50:47 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-23 00:06:59 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 00:09:00 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aedcc8a8ea65cb485bafbb4452d29c03e404cd5f
Cr-Commit-Position: refs/heads/master@{#350269}

Powered by Google App Engine
This is Rietveld 408576698