Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1359063003: Add missing 'return' keyword. (Closed)

Created:
5 years, 3 months ago by mdempsky
Modified:
5 years, 3 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add missing 'return' keyword. Discovered with experimental Clang plugin that flags temporary objects that are immediately destroyed.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M core/src/fxge/ge/fx_ge_fontmap.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
mdempsky
5 years, 3 months ago (2015-09-22 20:31:36 UTC) #2
Lei Zhang
5 years, 3 months ago (2015-09-22 20:34:43 UTC) #3
nice find, lgtm!

Powered by Google App Engine
This is Rietveld 408576698