Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 1359043005: Fix BluetoothConnection to disconnect when the underlying device disconnects. (Closed)

Created:
5 years, 3 months ago by Tim Song
Modified:
5 years, 2 months ago
Reviewers:
sacomoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@proximity_auth_system2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix BluetoothConnection to disconnect when the underlying device disconnects. BUG=527558 TEST=unit test and manual Committed: https://crrev.com/410dd75772d3c59593f3d78d6d3f0fbcbf6d9a78 Cr-Commit-Position: refs/heads/master@{#351238}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Patch Set 3 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -1 line) Patch
M components/proximity_auth/bluetooth_connection.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/proximity_auth/bluetooth_connection.cc View 1 2 2 chunks +12 lines, -1 line 0 comments Download
M components/proximity_auth/bluetooth_connection_unittest.cc View 4 chunks +32 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (6 generated)
Tim Song
5 years, 3 months ago (2015-09-24 02:38:07 UTC) #2
sacomoto
LGTM with nit. https://codereview.chromium.org/1359043005/diff/1/components/proximity_auth/bluetooth_connection.cc File components/proximity_auth/bluetooth_connection.cc (right): https://codereview.chromium.org/1359043005/diff/1/components/proximity_auth/bluetooth_connection.cc#newcode109 components/proximity_auth/bluetooth_connection.cc:109: Disconnect(); nit: Please check if |IsConnected()| ...
5 years, 3 months ago (2015-09-24 11:34:24 UTC) #3
Tim Song
https://codereview.chromium.org/1359043005/diff/1/components/proximity_auth/bluetooth_connection.cc File components/proximity_auth/bluetooth_connection.cc (right): https://codereview.chromium.org/1359043005/diff/1/components/proximity_auth/bluetooth_connection.cc#newcode109 components/proximity_auth/bluetooth_connection.cc:109: Disconnect(); On 2015/09/24 11:34:24, sacomoto wrote: > nit: Please ...
5 years, 2 months ago (2015-09-28 22:20:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359043005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359043005/20001
5 years, 2 months ago (2015-09-28 22:22:56 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/68487) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 2 months ago (2015-09-28 22:49:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359043005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359043005/40001
5 years, 2 months ago (2015-09-29 00:40:03 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-09-29 02:24:52 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 02:26:49 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/410dd75772d3c59593f3d78d6d3f0fbcbf6d9a78
Cr-Commit-Position: refs/heads/master@{#351238}

Powered by Google App Engine
This is Rietveld 408576698