Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 1359033005: Add ship sample (Closed)

Created:
5 years, 2 months ago by jvanverth1
Modified:
5 years, 2 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Tweak sample to match cocos demo better #

Patch Set 3 : Some last clean-ups #

Total comments: 8

Patch Set 4 : Update for comments #

Patch Set 5 : Address Win compile warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -0 lines) Patch
M gyp/SampleApp.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A samplecode/SampleShip.cpp View 1 2 3 4 1 chunk +156 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
jvanverth1
5 years, 2 months ago (2015-10-02 19:04:50 UTC) #2
robertphillips
lgtm + suggestions https://codereview.chromium.org/1359033005/diff/40001/samplecode/SampleShip.cpp File samplecode/SampleShip.cpp (right): https://codereview.chromium.org/1359033005/diff/40001/samplecode/SampleShip.cpp#newcode12 samplecode/SampleShip.cpp:12: #include "SkCanvas.h" Do we need SkDrawable.h ...
5 years, 2 months ago (2015-10-02 21:29:18 UTC) #3
jvanverth1
https://codereview.chromium.org/1359033005/diff/40001/samplecode/SampleShip.cpp File samplecode/SampleShip.cpp (right): https://codereview.chromium.org/1359033005/diff/40001/samplecode/SampleShip.cpp#newcode12 samplecode/SampleShip.cpp:12: #include "SkCanvas.h" On 2015/10/02 21:29:18, robertphillips wrote: > Do ...
5 years, 2 months ago (2015-10-05 17:04:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359033005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359033005/60001
5 years, 2 months ago (2015-10-05 17:05:10 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/3603)
5 years, 2 months ago (2015-10-05 17:06:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359033005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359033005/80001
5 years, 2 months ago (2015-10-05 17:59:00 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 18:05:10 UTC) #13
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/2f5bb3abfacadc8bdbc95381ab9d4fa218994a9f

Powered by Google App Engine
This is Rietveld 408576698