Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1359033002: Remove unused imports from tools/js2c.py (Closed)

Created:
5 years, 3 months ago by bnoordhuis
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove unused imports from tools/js2c.py Committed: https://crrev.com/fd1024ffb7e24bf03dd3fa3cd3806dd46b04ee6d Cr-Commit-Position: refs/heads/master@{#30941}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M tools/js2c.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bnoordhuis
The bz2 dependency in particular seems to be troublesome for some people. PTAL.
5 years, 3 months ago (2015-09-22 19:02:12 UTC) #2
Michael Achenbach
lgtm
5 years, 3 months ago (2015-09-23 07:32:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359033002/1
5 years, 2 months ago (2015-09-25 13:12:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-25 13:57:36 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 13:57:52 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fd1024ffb7e24bf03dd3fa3cd3806dd46b04ee6d
Cr-Commit-Position: refs/heads/master@{#30941}

Powered by Google App Engine
This is Rietveld 408576698