Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 135903012: Fix synthetic bold/italic for webfonts on windows (Closed)

Created:
6 years, 11 months ago by eae
Modified:
6 years, 11 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Fix synthetic bold/italic for webfonts on windows Add workaround for rendering synthetic bold/italic for webfonts on windows. The current skia implementation for synthetic bold/italic on windows results in pretty bad rendering, especially for synthetic bold. With this workaround in place the rendering matches the rendering in previous versions of Chrome and other browsers. TEST=fast/text/webfont-synthetic-bold.html BUG=332958 R=bungeman@chromium.org,dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165359

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/webfont-synthetic-bold.html View 1 chunk +27 lines, -0 lines 0 comments Download
M Source/platform/fonts/skia/FontCustomPlatformDataSkia.cpp View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
eae
6 years, 11 months ago (2014-01-17 23:11:36 UTC) #1
dglazkov
lgtm
6 years, 11 months ago (2014-01-17 23:14:53 UTC) #2
bungeman-chromium
lgtm This should work well as a temporary work-around for where this is seen the ...
6 years, 11 months ago (2014-01-17 23:25:03 UTC) #3
eae
On 2014/01/17 23:25:03, bungeman2 wrote: > lgtm > > This should work well as a ...
6 years, 11 months ago (2014-01-17 23:27:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/135903012/1
6 years, 11 months ago (2014-01-18 00:54:36 UTC) #5
commit-bot: I haz the power
Failed to trigger a try job on win_blink_rel HTTP Error 400: Bad Request
6 years, 11 months ago (2014-01-18 02:04:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/135903012/110001
6 years, 11 months ago (2014-01-18 02:04:33 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-18 03:06:49 UTC) #8
Message was sent while issue was closed.
Change committed as 165359

Powered by Google App Engine
This is Rietveld 408576698