Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: google_apis/gcm/gcm_client.h

Issue 135903005: [GCM] Reland: Introduce GCMClientFactory to create GCMClient for GCMProfileService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Patch to land Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « google_apis/gcm/engine/user_list_unittest.cc ('k') | google_apis/gcm/gcm_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/gcm/gcm_client.h
diff --git a/google_apis/gcm/gcm_client.h b/google_apis/gcm/gcm_client.h
index 26bb065bdba6a160b8485090e3c90d0f318c7d5f..914bb83cbe05df4af14544946f82f8bd89477f8f 100644
--- a/google_apis/gcm/gcm_client.h
+++ b/google_apis/gcm/gcm_client.h
@@ -12,10 +12,6 @@
#include "base/basictypes.h"
#include "google_apis/gcm/base/gcm_export.h"
-namespace base {
-class TaskRunner;
-}
-
namespace gcm {
// Interface that encapsulates the network communications with the Google Cloud
@@ -129,19 +125,10 @@ class GCM_EXPORT GCMClient {
// Called when the loading from the persistent store is done. The loading
// is triggered asynchronously when GCMClient is created.
virtual void OnLoadingCompleted() = 0;
-
- // Returns a task runner for file operations that may block. This is used
- // in writing to or reading from the persistent store.
- virtual base::TaskRunner* GetFileTaskRunner() = 0;
};
- // Returns the single instance. Multiple profiles share the same client
- // that makes use of the same MCS connection.
- static GCMClient* Get();
-
- // Passes a mocked instance for testing purpose.
- typedef GCMClient* (*TestingFactoryFunction)();
- static void SetTestingFactory(TestingFactoryFunction factory);
+ GCMClient();
+ virtual ~GCMClient();
// Sets the delegate to interact with related to a specific user.
// |username|: the username (email address) used to check in with the server.
@@ -189,9 +176,6 @@ class GCM_EXPORT GCMClient {
// Returns true if the loading from the persistent store is still in progress.
virtual bool IsLoading() const = 0;
-
- protected:
- virtual ~GCMClient() {}
};
} // namespace gcm
« no previous file with comments | « google_apis/gcm/engine/user_list_unittest.cc ('k') | google_apis/gcm/gcm_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698