Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 135903002: Revert 244407 "InstantExtended: remove dead code related to the ..." (Closed)

Created:
6 years, 11 months ago by scottmg
Modified:
6 years, 11 months ago
Reviewers:
samarth
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 244407 "InstantExtended: remove dead code related to the ..." InstantPolicyTest.NoThemeBackgroundChangeEventOnTabSwitch and others failing on XP, Mac 10.6, Linux ASAN. > InstantExtended: remove dead code related to the non-cacheable NTP. > > BUG=none > > Review URL: https://codereview.chromium.org/132733002 TBR=samarth@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244429

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+701 lines, -245 lines) Patch
M trunk/src/chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/search/instant_service.h View 7 chunks +33 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/search/instant_service.cc View 5 chunks +49 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/search/instant_service_unittest.cc View 4 chunks +38 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/search/search.h View 2 chunks +14 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/search/search.cc View 7 chunks +75 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/search/search_unittest.cc View 11 chunks +64 lines, -16 lines 0 comments Download
M trunk/src/chrome/browser/task_manager/extension_process_resource_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/browser/task_manager/panel_resource_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/browser/task_manager/tab_contents_resource_provider.cc View 6 chunks +15 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/task_manager/task_manager_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/browser/task_manager/task_manager_util.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/task_manager/task_manager_util_unittest.cc View 1 chunk +11 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/ui/browser_instant_controller.h View 3 chunks +14 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/browser_instant_controller.cc View 4 chunks +70 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/browser_navigator.cc View 6 chunks +20 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/ui/search/instant_controller.h View 2 chunks +10 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/search/instant_controller.cc View 2 chunks +34 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 21 chunks +124 lines, -37 lines 0 comments Download
M trunk/src/chrome/browser/ui/search/instant_extended_manual_interactive_uitest.cc View 2 chunks +28 lines, -1 line 0 comments Download
A + trunk/src/chrome/browser/ui/search/instant_loader.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/search/instant_loader.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/search/instant_ntp.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/search/instant_ntp.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/search/instant_ntp_prerenderer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/search/instant_ntp_prerenderer.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/search/instant_ntp_prerenderer_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/chrome/browser/ui/search/instant_page.h View 2 chunks +14 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/search/instant_page.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/search/instant_page_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/search/instant_test_utils.h View 4 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/search/instant_test_utils.cc View 7 chunks +36 lines, -5 lines 0 comments Download
A + trunk/src/chrome/browser/ui/search/instant_unload_handler.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/search/instant_unload_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/chrome/browser/ui/search/local_ntp_browsertest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/ui/search/search_tab_helper.cc View 2 chunks +3 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/webui/memory_internals/memory_internals_proxy.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M trunk/src/chrome/chrome_browser_ui.gypi View 1 chunk +8 lines, -0 lines 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
D trunk/src/chrome/test/data/instant_extended_ntp.html View 1 chunk +0 lines, -165 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scottmg
6 years, 11 months ago (2014-01-12 05:30:32 UTC) #1
scottmg
6 years, 11 months ago (2014-01-12 05:30:55 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r244429.

Powered by Google App Engine
This is Rietveld 408576698