Issue 13590002: [Android] Print the stack of deadlocked threads when sharding.

Issue 13590002: [Android] Print the stack of deadlocked threads when sharding. (Closed)

Created:
7 years, 8 months ago by craigdh

Modified:
7 years, 8 months ago

Reviewers:
frankf

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Print the stack of deadlocked threads when sharding. BUG=224382 TEST=unittest included Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192343

Patch Set 3 : watchdog.Watchdog -> watchdog_timer.WatchdogTimer #

Patch Set 5 : split test timeout and setup/cleanup timeout #

Total comments: 1

Patch Set 7 : additional '' 80 to make frankf happy #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+141 lines, -20 lines)			Patch
M	build/android/pylib/base/shard.py	View	1 2 3 4	10 chunks	+34 lines, -13 lines	0 comments	Download
M	build/android/pylib/base/shard_unittest.py	View	1 2 3 4	2 chunks	+3 lines, -1 line	0 comments	Download
M	build/android/pylib/browsertests/dispatch.py	View	1 2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download
M	build/android/pylib/gtest/dispatch.py	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	build/android/pylib/utils/reraiser_thread.py	View	1 2 3 4 5 6	4 chunks	+48 lines, -4 lines	0 comments	Download
M	build/android/pylib/utils/reraiser_thread_unittest.py	View	1 2 3	2 chunks	+16 lines, -0 lines	0 comments	Download
A	build/android/pylib/utils/watchdog_timer.py	View	1 2 3 4	1 chunk	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

frankf

Nice. Some nits. https://codereview.chromium.org/13590002/diff/2001/build/android/pylib/base/shard.py File build/android/pylib/base/shard.py (right): https://codereview.chromium.org/13590002/diff/2001/build/android/pylib/base/shard.py#newcode13 build/android/pylib/base/shard.py:13: from pylib.utils import watchdog use more ...

7 years, 8 months ago (2013-04-03 20:49:51 UTC) #2

craigdh

https://codereview.chromium.org/13590002/diff/2001/build/android/pylib/base/shard.py File build/android/pylib/base/shard.py (right): https://codereview.chromium.org/13590002/diff/2001/build/android/pylib/base/shard.py#newcode13 build/android/pylib/base/shard.py:13: from pylib.utils import watchdog On 2013/04/03 20:49:52, frankf wrote: ...

7 years, 8 months ago (2013-04-03 21:17:47 UTC) #3

frankf

lgtm with nit https://codereview.chromium.org/13590002/diff/2004/build/android/pylib/utils/reraiser_thread.py File build/android/pylib/utils/reraiser_thread.py (right): https://codereview.chromium.org/13590002/diff/2004/build/android/pylib/utils/reraiser_thread.py#newcode110 build/android/pylib/utils/reraiser_thread.py:110: logging.critical('STACK DUMP FOR TIMED OUT THREAD ...

7 years, 8 months ago (2013-04-03 23:17:48 UTC) #6

craigdh

7 years, 8 months ago (2013-04-04 16:23:30 UTC) #7

Message was sent while issue was closed.

Committed patchset #7 manually as r192343 (presubmit successful).

Expand Messages | Collapse Messages