Add unit test for glsl-construct-vec-mat-index's expectations.

Add unit test for glsl-construct-vec-mat-index's expectations.

Add the ability to override the browser_type of the fake browser in
telemetry.testing.fakes.

The unit test is working as expected. Need to run this test repeatedly
on Windows to understand whether the test expectation isn't being
picked up, or whether the flaky test handling is unable to recover
from the kind of failure that's happening.

BUG=534697
Committed: https://crrev.com/c8c06bd814d411066d1f353915a490836efb6d1b
Cr-Commit-Position: refs/heads/master@{#350254}

[Ken Russell (switch to Gerrit), 2015-09-22 03:30:15]

kbr@chromium.org changed reviewers:
+ bajones@chromium.org, nednguyen@google.com, zmo@chromium.org

[Ken Russell (switch to Gerrit), 2015-09-22 03:30:16]

nednguyen: please review change to fakes/__init__.py. Also feel free to review
the new unit test. Apologies for diving into the internals of the SystemInfo and
GPUInfo objects. Any suggestions for doing this more cleanly appreciated.

bajones, zmo: please review the new unit test.

Thanks.

https://codereview.chromium.org/1358943002/diff/1/content/test/gpu/gpu_tests/...
File content/test/gpu/gpu_tests/gpu_test_base_unittest.py (left):

https://codereview.chromium.org/1358943002/diff/1/content/test/gpu/gpu_tests/...
content/test/gpu/gpu_tests/gpu_test_base_unittest.py:20: return
os.path.join(gpu_dir, *subdirs)
This was left over from the previous cleanup.

[Ken Russell (switch to Gerrit), 2015-09-22 05:26:39]

Note: I split off the test expectation update in
https://codereview.chromium.org/1357353002 and am CQ'ing it TBR'd to fix the
flakiness on the tryservers.

[Ken Russell (switch to Gerrit), 2015-09-22 06:50:52]

Recategorized the purpose of this CL.

[bajones, 2015-09-22 16:50:33]

LGTM

[nednguyen, 2015-09-22 16:55:53]

lgtm

[Ken Russell (switch to Gerrit), 2015-09-22 19:52:04]

Revised. Added fake_win_amd_gpu_info, grabbed off the bots, and stopped using
Telemetry's internal fields.

[nednguyen, 2015-09-22 20:16:54]

lgtm again

https://codereview.chromium.org/1358943002/diff/40001/content/test/gpu/gpu_te...
File content/test/gpu/gpu_tests/webgl_conformance_expectations_unittest.py
(right):

https://codereview.chromium.org/1358943002/diff/40001/content/test/gpu/gpu_te...
content/test/gpu/gpu_tests/webgl_conformance_expectations_unittest.py:14: import
pdb
style nit: unused import.

Tip: in telemetry, we have tools/telemetry/pylintrc that is more restricted that
the default one.

[Ken Russell (switch to Gerrit), 2015-09-22 20:37:01]

https://codereview.chromium.org/1358943002/diff/40001/content/test/gpu/gpu_te...
File content/test/gpu/gpu_tests/webgl_conformance_expectations_unittest.py
(right):

https://codereview.chromium.org/1358943002/diff/40001/content/test/gpu/gpu_te...
content/test/gpu/gpu_tests/webgl_conformance_expectations_unittest.py:14: import
pdb
On 2015/09/22 20:16:54, nednguyen wrote:
> style nit: unused import.

Thanks. Fixed.

> Tip: in telemetry, we have tools/telemetry/pylintrc that is more restricted
that
> the default one.

Could you tell me how to deploy this into src/content/tests/gpu? We don't have a
directory-specific PRESUBMIT.py and I don't know how to set one up.

[Ken Russell (switch to Gerrit), 2015-09-22 20:38:13]

The CQ bit was checked by kbr@chromium.org

[Ken Russell (switch to Gerrit), 2015-09-22 20:38:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
bajones@chromium.org, nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/1358943002/#ps40002
(title: "Removed unused import.")

[commit-bot: I haz the power, 2015-09-22 20:38:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1358943002/40002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1358943002/40002

[nednguyen, 2015-09-22 20:50:29]

On 2015/09/22 20:37:01, Ken Russell wrote:
>
https://codereview.chromium.org/1358943002/diff/40001/content/test/gpu/gpu_te...
> File content/test/gpu/gpu_tests/webgl_conformance_expectations_unittest.py
> (right):
> 
>
https://codereview.chromium.org/1358943002/diff/40001/content/test/gpu/gpu_te...
> content/test/gpu/gpu_tests/webgl_conformance_expectations_unittest.py:14:
import
> pdb
> On 2015/09/22 20:16:54, nednguyen wrote:
> > style nit: unused import.
> 
> Thanks. Fixed.
> 
> > Tip: in telemetry, we have tools/telemetry/pylintrc that is more restricted
> that
> > the default one.
> 
> Could you tell me how to deploy this into src/content/tests/gpu? We don't have
a
> directory-specific PRESUBMIT.py and I don't know how to set one up.

Hi Ken, you can take this patch https://codereview.chromium.org/1359043003 &
fix/suppress the lint errors as needed.

[commit-bot: I haz the power, 2015-09-22 22:14:05]

Committed patchset #4 (id:40002)

[commit-bot: I haz the power, 2015-09-22 22:16:28]

Patchset 4 (id:??) landed as
https://crrev.com/c8c06bd814d411066d1f353915a490836efb6d1b
Cr-Commit-Position: refs/heads/master@{#350254}