Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 1358913003: Remove nss* references from libjingle gyp file. (Closed)

Created:
5 years, 3 months ago by torbjorng
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebRTC's nssidentity.{cc,h} and nssstreamadapter.{cc,h} from libjingle NaCl gyp file. BUG=webrtc:4497 Committed: https://crrev.com/4bf04ff839fbad8348d970c0e677309df8bffb5a Cr-Commit-Position: refs/heads/master@{#350146}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/libjingle/libjingle_nacl.gyp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358913003/1
5 years, 3 months ago (2015-09-22 12:10:59 UTC) #3
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 3 months ago (2015-09-22 12:11:01 UTC) #5
torbjorng
PTAL, for dry run.
5 years, 3 months ago (2015-09-22 12:13:54 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358913003/1
5 years, 3 months ago (2015-09-22 12:16:09 UTC) #8
kjellander_chromium
Please make it clear this is only the NaCl libjingle target (the regular doesn't have ...
5 years, 3 months ago (2015-09-22 12:16:44 UTC) #9
torbjorng
On 2015/09/22 12:16:44, kjellander (chromium) wrote: > Please make it clear this is only the ...
5 years, 3 months ago (2015-09-22 13:08:39 UTC) #10
kjellander_chromium
lgtm I changed to BUG=webrtc:4497 for you.
5 years, 3 months ago (2015-09-22 13:12:09 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-22 13:15:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358913003/1
5 years, 3 months ago (2015-09-22 13:24:49 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-22 13:29:10 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 13:30:08 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4bf04ff839fbad8348d970c0e677309df8bffb5a
Cr-Commit-Position: refs/heads/master@{#350146}

Powered by Google App Engine
This is Rietveld 408576698