Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1358903005: Linux: Depend on liberation-fonts package for RPMs. (Closed)

Created:
5 years, 3 months ago by Lei Zhang
Modified:
5 years, 3 months ago
Reviewers:
Michael Moss
CC:
chromium-reviews, grt+watch_chromium.org, Michael Moss, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Linux: Depend on liberation-fonts package for RPMs. The previous try in r342645 was reverted because Fedora did not have a liberation-fonts virtual package. Fedora has since added the missing virtual pacakge per our request to supported distros - Fedora 21 and newer. So now we can fix the mismatch vs .debs, which added this dependency in r342854. BUG=369991 Committed: https://crrev.com/a6df68559fd91f3bf3273c5e46d1c6a7b2132b8c Cr-Commit-Position: refs/heads/master@{#350101}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/installer/linux/rpm/build.sh View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Lei Zhang
5 years, 3 months ago (2015-09-22 01:50:41 UTC) #2
Michael Moss
lgtm
5 years, 3 months ago (2015-09-22 02:09:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358903005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358903005/1
5 years, 3 months ago (2015-09-22 02:12:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-22 03:28:44 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a6df68559fd91f3bf3273c5e46d1c6a7b2132b8c Cr-Commit-Position: refs/heads/master@{#350101}
5 years, 3 months ago (2015-09-22 03:29:34 UTC) #7
Lei Zhang
5 years, 2 months ago (2015-09-29 05:54:15 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1380473002/ by thestig@chromium.org.

The reason for reverting is: Fedora 21 is still broken..

Powered by Google App Engine
This is Rietveld 408576698