Use built Chromium dependencies in run_gpu_test.

Use built Chromium dependencies in run_gpu_test.

BUG=466877
Committed: https://crrev.com/43c949fab798f29c05e5158c26b30fe3ac10ebdf
Cr-Commit-Position: refs/heads/master@{#351233}

[aiolos (Not reviewing), 2015-09-22 20:26:04]

aiolos@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2015-09-22 21:20:34]

This looks fine in principle, but a lot of tests are broken in bad ways in the
tryjobs. Is that expected?

[aiolos (Not reviewing), 2015-09-22 21:33:04]

On 2015/09/22 21:20:34, Ken Russell wrote:
> This looks fine in principle, but a lot of tests are broken in bad ways in the
> tryjobs. Is that expected?

The tree was closed at the time, so it's not unexpected. Since the failures
aren't in gpu tests, I'm guessing that was the cause. But I definitely wouldn't
land it until they passed to be safe.
Also, I should add os.abspath to be safe.

[Ken Russell (switch to Gerrit), 2015-09-22 21:42:05]

On 2015/09/22 21:33:04, aiolos wrote:
> On 2015/09/22 21:20:34, Ken Russell wrote:
> > This looks fine in principle, but a lot of tests are broken in bad ways in
the
> > tryjobs. Is that expected?
> 
> The tree was closed at the time, so it's not unexpected. Since the failures
> aren't in gpu tests, I'm guessing that was the cause. But I definitely
wouldn't
> land it until they passed to be safe.

OK. LGTM then.

> Also, I should add os.abspath to be safe.

Seems fine.

[aiolos (Not reviewing), 2015-09-23 17:23:53]

Since this CL is still waiting on codereview.com/1361523003, I updated it to fix
run_unittests as well. PTAL

[aiolos (Not reviewing), 2015-09-23 17:24:50]

On 2015/09/23 17:23:53, aiolos wrote:
> Since this CL is still waiting on codereview.com/1361523003, I updated it to
fix
> run_unittests as well. PTAL

Sorry, I meant https://codereview.chromium.org/1361523003/

[Ken Russell (switch to Gerrit), 2015-09-23 17:42:18]

Still LGTM

https://codereview.chromium.org/1358903004/diff/40001/content/telemetry.isolate
File content/telemetry.isolate (right):

https://codereview.chromium.org/1358903004/diff/40001/content/telemetry.isola...
content/telemetry.isolate:29: '../tools/perf/core/binary_dependencies.json',
Should this be added here or in the isolates which depend on this one? Since
crash_service.exe is built at the chrome/ level and this isolate's in content/
there's a layering problem where this one can't directly include the built
executable, but this JSON file specifies that it might exist.

It's not a big problem either way but it would be nice if the base Telemetry
isolate could directly include all of its binary dependencies. Maybe we should
move it out of content/ and into chrome/.

[aiolos (Not reviewing), 2015-09-23 18:58:45]

https://codereview.chromium.org/1358903004/diff/40001/content/telemetry.isolate
File content/telemetry.isolate (right):

https://codereview.chromium.org/1358903004/diff/40001/content/telemetry.isola...
content/telemetry.isolate:29: '../tools/perf/core/binary_dependencies.json',
On 2015/09/23 17:42:17, Ken Russell wrote:
> Should this be added here or in the isolates which depend on this one? Since
> crash_service.exe is built at the chrome/ level and this isolate's in content/
> there's a layering problem where this one can't directly include the built
> executable, but this JSON file specifies that it might exist.
> 
> It's not a big problem either way but it would be nice if the base Telemetry
> isolate could directly include all of its binary dependencies. Maybe we should
> move it out of content/ and into chrome/.

This file is actually from https://codereview.chromium.org/1361523003/ and will
disappear after rebasing. I also moved the json file out of the
telemetry.isolate, and into it's own isolate which is currently in content.
Should I move it to chrome?

[Ken Russell (switch to Gerrit), 2015-09-23 19:19:02]

https://codereview.chromium.org/1358903004/diff/40001/content/telemetry.isolate
File content/telemetry.isolate (right):

https://codereview.chromium.org/1358903004/diff/40001/content/telemetry.isola...
content/telemetry.isolate:29: '../tools/perf/core/binary_dependencies.json',
On 2015/09/23 18:58:45, aiolos wrote:
> On 2015/09/23 17:42:17, Ken Russell wrote:
> > Should this be added here or in the isolates which depend on this one? Since
> > crash_service.exe is built at the chrome/ level and this isolate's in
content/
> > there's a layering problem where this one can't directly include the built
> > executable, but this JSON file specifies that it might exist.
> > 
> > It's not a big problem either way but it would be nice if the base Telemetry
> > isolate could directly include all of its binary dependencies. Maybe we
should
> > move it out of content/ and into chrome/.
> 
> This file is actually from https://codereview.chromium.org/1361523003/ and
will
> disappear after rebasing. I also moved the json file out of the
> telemetry.isolate, and into it's own isolate which is currently in content.
> Should I move it to chrome?

Yes, given that Telemetry has implicit dependencies on targets from chrome/, I
think this file should be moved back to chrome/. That probably implies
telemetry_gpu_unittests.isolate needs to be moved too.

[aiolos (Not reviewing), 2015-09-29 00:03:14]

Patchset #4 (id:60001) has been deleted

[Ken Russell (switch to Gerrit), 2015-09-29 00:35:31]

Still LGTM.

[aiolos (Not reviewing), 2015-09-29 00:36:21]

The CQ bit was checked by aiolos@chromium.org

[commit-bot: I haz the power, 2015-09-29 00:36:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1358903004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1358903004/80001

[commit-bot: I haz the power, 2015-09-29 02:20:36]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-09-29 02:22:44]

Patchset 4 (id:??) landed as
https://crrev.com/43c949fab798f29c05e5158c26b30fe3ac10ebdf
Cr-Commit-Position: refs/heads/master@{#351233}

[aiolos (Not reviewing), 2015-09-29 05:24:04]

A revert of this CL (patchset #4 id:80001) has been created in
https://codereview.chromium.org/1377493004/ by aiolos@chromium.org.

The reason for reverting is: Reverting until 
https://codereview.chromium.org/1361523003/ re-lands.
.