Documentation for "not_allowed" value in "incognito" manifest field.

Documentation for "not_allowed" value in "incognito" manifest field.

This feature was submitted in https://codereview.chromium.org/1351223003

BUG=455756
Committed: https://crrev.com/a08f03181c48aea3ff38f9ebc2f55f5b2b5b9df7
Cr-Commit-Position: refs/heads/master@{#350844}

[Not at Google. Contact bengr, 2015-09-21 23:15:03]

kundaji@chromium.org changed reviewers:
+ mkearney@chromium.org

[Not at Google. Contact bengr, 2015-09-21 23:15:30]

mkearney:
  chrome/common/extensions/docs/templates/articles/manifest/incognito.html
  chrome/common/extensions/docs/templates/json/manifest.json

[Not at Google. Contact bengr, 2015-09-23 16:47:58]

Ping. 

mkearney@, can you please take a look.

[Not at Google. Contact bengr, 2015-09-24 16:45:30]

kundaji@chromium.org changed reviewers:
+ mkearney1@chromium.org, mkwst@chromium.org
- mkearney@chromium.org

[Not at Google. Contact bengr, 2015-09-24 16:46:47]

kundaji@chromium.org changed reviewers:
+ mkearney@chromium.org
- mkearney1@chromium.org

[Not at Google. Contact bengr, 2015-09-24 16:46:47]

mkearney,mkwst:
  chrome/common/extensions/docs/templates/articles/manifest/incognito.html
  chrome/common/extensions/docs/templates/json/manifest.json

[not at google - send to devlin, 2015-09-24 17:39:51]

kalman@chromium.org changed reviewers:
+ kalman@chromium.org

[not at google - send to devlin, 2015-09-24 17:39:51]

lgtm

https://codereview.chromium.org/1358903003/diff/1/chrome/common/extensions/do...
File chrome/common/extensions/docs/templates/articles/manifest/incognito.html
(right):

https://codereview.chromium.org/1358903003/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/templates/articles/manifest/incognito.html:40: <h2
id="not_allowed">Not Allowed</h2>
s/Allowed/allowed (all other headers seem to follow this convention, though
Meggin, if it should be capitalised the others should as well)

https://codereview.chromium.org/1358903003/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/templates/articles/manifest/incognito.html:42: The
{{platform}} will not be allowed to be enabled in incognito mode. This
I would phrase this as "cannot be enabled".

https://codereview.chromium.org/1358903003/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/templates/articles/manifest/incognito.html:43:
option can only be used since Chrome 47.
"This option can only be used since Chrome 47."

more concise:

"Available from Chrome 47."

[Not at Google. Contact bengr, 2015-09-25 16:17:27]

kundaji@chromium.org changed reviewers:
- mkwst@chromium.org

[Not at Google. Contact bengr, 2015-09-25 16:17:45]

Thanks for the review!

https://codereview.chromium.org/1358903003/diff/1/chrome/common/extensions/do...
File chrome/common/extensions/docs/templates/articles/manifest/incognito.html
(right):

https://codereview.chromium.org/1358903003/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/templates/articles/manifest/incognito.html:40: <h2
id="not_allowed">Not Allowed</h2>
On 2015/09/24 17:39:51, kalman wrote:
> s/Allowed/allowed (all other headers seem to follow this convention, though
> Meggin, if it should be capitalised the others should as well)

Done.

https://codereview.chromium.org/1358903003/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/templates/articles/manifest/incognito.html:42: The
{{platform}} will not be allowed to be enabled in incognito mode. This
On 2015/09/24 17:39:51, kalman wrote:
> I would phrase this as "cannot be enabled".

Done.

https://codereview.chromium.org/1358903003/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/templates/articles/manifest/incognito.html:43:
option can only be used since Chrome 47.
On 2015/09/24 17:39:51, kalman wrote:
> "This option can only be used since Chrome 47."
> 
> more concise:
> 
> "Available from Chrome 47."

Done.

[Not at Google. Contact bengr, 2015-09-25 16:17:56]

The CQ bit was checked by kundaji@chromium.org

[Not at Google. Contact bengr, 2015-09-25 16:17:57]

The patchset sent to the CQ was uploaded after l-g-t-m from kalman@chromium.org
Link to the patchset: https://codereview.chromium.org/1358903003/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2015-09-25 16:18:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1358903003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1358903003/20001

[commit-bot: I haz the power, 2015-09-25 16:30:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-25 16:31:10]

Patchset 2 (id:??) landed as
https://crrev.com/a08f03181c48aea3ff38f9ebc2f55f5b2b5b9df7
Cr-Commit-Position: refs/heads/master@{#350844}