Issue 13589003: Make depot_tools' fetch work on windows if 'gclient' isn't in the path

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13589003: Make depot_tools' fetch work on windows if 'gclient' isn't in the path (Closed)

Created:
7 years, 8 months ago by Dirk Pranke

Modified:
7 years, 8 months ago

Reviewers:
agable, M-A Ruel, szager1

CC:
chromium-reviews, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Make depot_tools' fetch work on windows if 'gclient' isn't in the path TBR=maruel@chromium.org, agable@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192170

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	fetch.py	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

Marc-Antoine, I think it's safe to assume that git is in the path (and thus ...

7 years, 8 months ago (2013-04-03 22:09:53 UTC) #3

M-A Ruel

7 years, 8 months ago (2013-04-04 06:44:10 UTC) #4

Message was sent while issue was closed.

On 2013/04/03 22:09:53, Dirk Pranke wrote:
> Marc-Antoine, I think it's safe to assume that git is in the path (and thus
> subprocess.call() will work), right?

There could possibly be a race condition on the very initial checkout. You
should check with Stefan.

Expand Messages | Collapse Messages