content/test/data/media/getusermedia.html - Issue 1358883003: Use GpuMemoryBufferVideoFramePool for WebMediaPlayerMS and MediaStreamVideoRendererSink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/data/media/getusermedia.html

Issue 1358883003: Use GpuMemoryBufferVideoFramePool for WebMediaPlayerMS and MediaStreamVideoRendererSink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@send-gmbs

Patch Set: Test issues. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/renderer/layout_test/test_media_stream_renderer_factory.cc ('k') | content/test/data/media/webrtc_test_utilities.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/test/data/media/getusermedia.html

diff --git a/content/test/data/media/getusermedia.html b/content/test/data/media/getusermedia.html

index e4723636005fadec7b4e39b0989a7c86778324b1..7a7868db0e33fa8b9dd786c16e6086e8e6422234 100644

--- a/content/test/data/media/getusermedia.html

+++ b/content/test/data/media/getusermedia.html

@@ -483,12 +483,14 @@

// Walk horizontally counting light green pixels.

for (var x = 0; x < aperture; ++x) {

- if (pixels.data[4 * x + 1] != COLOR_BACKGROUND_GREEN)

+ if (Math.abs(pixels.data[4 * x + 1] - COLOR_BACKGROUND_GREEN) >

+ COLOR_BACKGROUND_GREEN_THRESHOLD)

phoglund_chromium 2015/10/13 08:07:01 I think you might as well inline the threshold con

emircan 2015/10/13 18:12:27 Done.

lightGreenPixelsX++;

}

// Walk vertically counting light green pixels.

for (var y = 0; y < aperture; ++y) {

- if (pixels.data[4 * y * aperture + 1] != COLOR_BACKGROUND_GREEN)

+ if (Math.abs(pixels.data[4 * y * aperture + 1] -

+ COLOR_BACKGROUND_GREEN) > COLOR_BACKGROUND_GREEN_THRESHOLD)

lightGreenPixelsY++;

}

if (lightGreenPixelsX > maxLightGreenPixelsX)