Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 1358873002: Crash fix for when running under the Android emulator (Closed)

Created:
5 years, 3 months ago by davve
Modified:
5 years, 2 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Crash fix for when running under the Android emulator For unknown reasons some versions of the Android emulator returns NULL when asked for GL_SHADING_LANGUAGE_VERSION. Avoid passing NULL to std::string, which causes undefined behavior. Committed: https://crrev.com/4af61ccffa3d1af66d2f5c8df0028187ccfadd27 Cr-Commit-Position: refs/heads/master@{#353246}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M gpu/config/gpu_info_collector_android.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358873002/1
5 years, 3 months ago (2015-09-21 15:13:55 UTC) #2
davve
Got crashes on start-up when following: https://chromium.googlesource.com/chromium/src/+/master/docs/android_test_instructions.md Mentioned in http://code.google.com/p/android/issues/detail?id=78977 that it might be a ...
5 years, 3 months ago (2015-09-21 15:16:58 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-21 16:22:51 UTC) #6
Tobias Sargeant
LGTM, apart from the comment about glGetError(). https://codereview.chromium.org/1358873002/diff/1/gpu/config/gpu_info_collector_android.cc File gpu/config/gpu_info_collector_android.cc (right): https://codereview.chromium.org/1358873002/diff/1/gpu/config/gpu_info_collector_android.cc#newcode220 gpu/config/gpu_info_collector_android.cc:220: if (const ...
5 years, 3 months ago (2015-09-22 12:12:04 UTC) #7
davve
https://codereview.chromium.org/1358873002/diff/1/gpu/config/gpu_info_collector_android.cc File gpu/config/gpu_info_collector_android.cc (right): https://codereview.chromium.org/1358873002/diff/1/gpu/config/gpu_info_collector_android.cc#newcode220 gpu/config/gpu_info_collector_android.cc:220: if (const char* glsl_version_cstring = reinterpret_cast<const char*>( On 2015/09/22 ...
5 years, 3 months ago (2015-09-23 10:24:51 UTC) #8
Tobias Sargeant
On 2015/09/23 10:24:51, David Vest wrote: > While I agree with your logic, glGetError() returns ...
5 years, 3 months ago (2015-09-23 10:51:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358873002/1
5 years, 3 months ago (2015-09-23 11:34:41 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/102851)
5 years, 3 months ago (2015-09-23 11:44:06 UTC) #13
davve
On 2015/09/23 11:44:06, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 2 months ago (2015-10-07 11:48:58 UTC) #15
no sievers
On 2015/10/07 11:48:58, David Vest wrote: > On 2015/09/23 11:44:06, commit-bot: I haz the power ...
5 years, 2 months ago (2015-10-07 17:18:15 UTC) #16
davve
On 2015/10/07 17:18:15, sievers wrote: > lgtm. i wonder if it also generates a GL ...
5 years, 2 months ago (2015-10-09 06:46:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358873002/20001
5 years, 2 months ago (2015-10-09 06:50:09 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-09 07:51:33 UTC) #21
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 07:52:30 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4af61ccffa3d1af66d2f5c8df0028187ccfadd27
Cr-Commit-Position: refs/heads/master@{#353246}

Powered by Google App Engine
This is Rietveld 408576698