Issue 135883002: Regression(r164927): gcc 4.8 build with C++11 support is broken

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 135883002: Regression(r164927): gcc 4.8 build with C++11 support is broken (Closed)

Created:
6 years, 11 months ago by Inactive

Modified:
6 years, 11 months ago

Reviewers:
abarth-chromium, eseidel

CC:
blink-reviews, yurys+blink_chromium.org, loislo+blink_chromium.org, adamk+blink_chromium.org, Inactive, abarth-chromium, Nico

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Regression(r164927): gcc 4.8 build with C++11 support is broken Fix C++11 build with gcc 4.8 by moving the OVERRIDE before the WTF_ATTRIBUTE_PRINTF(). Although clang did not seem to have trouble with it, gcc refuses to compile unless OVERRIDE is right after the method method and before the WTF_ATTRIBUTE_PRINTF(). R=eseidel, abarth BUG=333316 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164944

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/wtf/FilePrintStream.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/135883002/1

6 years, 11 months ago (2014-01-12 03:38:09 UTC) #3

Message was sent while issue was closed.

Change committed as 164944

Expand Messages | Collapse Messages