chrome/browser/chromeos/login/screens/hid_detection_screen.h - Issue 1358783002: Cleanup: Pass std::string as const reference from chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/screens/hid_detection_screen.h

Issue 1358783002: Cleanup: Pass std::string as const reference from chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase against ToT Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/kiosk_browsertest.cc ('k') | chrome/browser/chromeos/login/screens/hid_detection_screen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/screens/hid_detection_screen.h

diff --git a/chrome/browser/chromeos/login/screens/hid_detection_screen.h b/chrome/browser/chromeos/login/screens/hid_detection_screen.h

index df2c7036ad27774895e1c093c68bc179cf081e49..42860a223d6077f3b0416cda1e7558a0821b4b7d 100644

--- a/chrome/browser/chromeos/login/screens/hid_detection_screen.h

+++ b/chrome/browser/chromeos/login/screens/hid_detection_screen.h

@@ -174,8 +174,7 @@ class HIDDetectionScreen : public HIDDetectionModel,

void SendKeyboardDeviceNotification();

// Helper method. Sets device name or placeholder if the name is empty.

- void SetKeyboardDeviceName_(std::string name);

+ void SetKeyboardDeviceName_(const std::string& name);

HIDDetectionView* view_;