Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1358763004: Implement getConfiguration in WebUSBDeviceImpl. (Closed)

Created:
5 years, 3 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 3 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement getConfiguration in WebUSBDeviceImpl. This USBDevice method allows a site to determine the current configuration state of the device. A follow-up to this change will make WebUSBDevice::getConfiguration a pure virtual method. Blink change: https://codereview.chromium.org/1352283005/ BUG=492204 Committed: https://crrev.com/8b606624ecade50e8b5be2c9d423c976ac23ce7a Cr-Commit-Position: refs/heads/master@{#350212}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
M content/renderer/usb/web_usb_device_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/usb/web_usb_device_impl.cc View 3 chunks +22 lines, -0 lines 0 comments Download
M device/devices_app/usb/device_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/devices_app/usb/public/interfaces/device.mojom View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Reilly Grant (use Gerrit)
PTAL
5 years, 3 months ago (2015-09-22 00:21:21 UTC) #2
Ken Rockot(use gerrit already)
lgtm
5 years, 3 months ago (2015-09-22 17:47:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358763004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358763004/1
5 years, 3 months ago (2015-09-22 17:58:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-22 19:30:33 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 19:31:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b606624ecade50e8b5be2c9d423c976ac23ce7a
Cr-Commit-Position: refs/heads/master@{#350212}

Powered by Google App Engine
This is Rietveld 408576698