Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: test/cctest/test-api.cc

Issue 1358703003: Changed scavenge GC to collect unmodified references (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Checks if the object is not active inaddition to unmodified before reclaiming it. The browser test … Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/heap.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index 7ba4a3c4a923de2f38d9aa8d2453d880a26a8b92..65967db08199648fed8fbf19f6eb930be005b19e 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -6536,7 +6536,8 @@ static void IndependentWeakHandle(bool global_gc, bool interlinked) {
Local<Object> b(v8::Object::New(iso));
object_a.handle.Reset(iso, a);
object_b.handle.Reset(iso, b);
- if (interlinked) {
+ if (interlinked &&
+ !v8::internal::FLAG_scavenge_reclaim_unmodified_objects) {
a->Set(v8_str("x"), b);
b->Set(v8_str("x"), a);
}
@@ -6548,7 +6549,9 @@ static void IndependentWeakHandle(bool global_gc, bool interlinked) {
// We are relying on this creating a big flag array and reserving the space
// up front.
v8::Handle<Value> big_array = CompileRun("new Array(5000)");
- a->Set(v8_str("y"), big_array);
+ if (!v8::internal::FLAG_scavenge_reclaim_unmodified_objects) {
+ a->Set(v8_str("y"), big_array);
+ }
big_heap_size = CcTest::heap()->SizeOfObjects();
}
« no previous file with comments | « src/heap/heap.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698