Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 13586004: add a -n/--dry-run to the new fetch command in depot_tools (Closed)

Created:
7 years, 8 months ago by Dirk Pranke
Modified:
7 years, 8 months ago
Reviewers:
agable, iannucci, M-A Ruel
CC:
chromium-reviews, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Visibility:
Public.

Description

add a -n/--dry-run to the new fetch command in depot_tools This is done as a hack since we don't really have real option parsing :(. R=iannucci@chromium.org, agable@chromium.org, maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192154

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -17 lines) Patch
M fetch.py View 9 chunks +23 lines, -17 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
agable
LGTM https://codereview.chromium.org/13586004/diff/1/fetch.py File fetch.py (right): https://codereview.chromium.org/13586004/diff/1/fetch.py#newcode165 fetch.py:165: argv.pop(1) This is the best way to do ...
7 years, 8 months ago (2013-04-03 21:06:59 UTC) #1
Dirk Pranke
7 years, 8 months ago (2013-04-03 21:09:11 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r192154.

Powered by Google App Engine
This is Rietveld 408576698