Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1358563002: add new gm to test overlapping lcd text (Closed)

Created:
5 years, 3 months ago by joshua.litt
Modified:
5 years, 3 months ago
Reviewers:
joshualitt, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add new gm to test overlapping lcd text BUG=skia: Committed: https://skia.googlesource.com/skia/+/496d29f6b273340efa59f1077d9338688c685f1b

Patch Set 1 #

Total comments: 1

Patch Set 2 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -0 lines) Patch
A gm/lcdoverlap.cpp View 1 1 chunk +100 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
joshualitt
ptal
5 years, 3 months ago (2015-09-18 18:14:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358563002/1
5 years, 3 months ago (2015-09-18 18:50:59 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 3 months ago (2015-09-18 18:51:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358563002/1
5 years, 3 months ago (2015-09-18 18:53:38 UTC) #8
egdaniel
lgtm with nit https://codereview.chromium.org/1358563002/diff/1/gm/lcdoverlap.cpp File gm/lcdoverlap.cpp (right): https://codereview.chromium.org/1358563002/diff/1/gm/lcdoverlap.cpp#newcode10 gm/lcdoverlap.cpp:10: * Tests text rendering with LCD ...
5 years, 3 months ago (2015-09-18 18:54:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358563002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358563002/20001
5 years, 3 months ago (2015-09-18 18:57:09 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 19:03:16 UTC) #15
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/496d29f6b273340efa59f1077d9338688c685f1b

Powered by Google App Engine
This is Rietveld 408576698