Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1358553002: PPC: [stubs] Refactor StringCompareStub and use it for HStringCompareAndBranch. (Closed)

Created:
5 years, 3 months ago by MTBrandyberry
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [stubs] Refactor StringCompareStub and use it for HStringCompareAndBranch. Port 8016547c8e6fde00fff0a1791f3c83b444d8af25 Original commit message: The StringCompareStub used to take its parameters on the (JavaScript) stack, which made it impossible to use in TurboFan. Actually StringCompareStub was currently completely unused. This changes the calling convention to something TurboFan compatible and introduces a CallInterfaceDescriptor for StringCompareStub. It also changes HStringCompareAndBranch to use the StringCompareStub instead of using the full blown CompareICStub for a stupid string comparison. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Committed: https://crrev.com/d4d2ea7b8a28d900aa74b9fa83fd0b5e6bb17b6c Cr-Commit-Position: refs/heads/master@{#30837}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -29 lines) Patch
M src/ppc/code-stubs-ppc.cc View 1 chunk +14 lines, -16 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 2 chunks +5 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358553002/1
5 years, 3 months ago (2015-09-18 18:10:57 UTC) #2
MTBrandyberry
5 years, 3 months ago (2015-09-18 18:28:52 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-18 18:32:58 UTC) #5
dstence
lgtm
5 years, 3 months ago (2015-09-18 18:38:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358553002/1
5 years, 3 months ago (2015-09-18 18:38:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 18:40:37 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 18:40:47 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4d2ea7b8a28d900aa74b9fa83fd0b5e6bb17b6c
Cr-Commit-Position: refs/heads/master@{#30837}

Powered by Google App Engine
This is Rietveld 408576698