Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: mojo/package_manager/content_handler_connection.cc

Issue 1358533004: Move more of ContentHandler handling into PackageManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/package_manager/content_handler_connection.h ('k') | mojo/package_manager/content_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/package_manager/content_handler_connection.cc
diff --git a/mojo/shell/content_handler_connection.cc b/mojo/package_manager/content_handler_connection.cc
similarity index 71%
rename from mojo/shell/content_handler_connection.cc
rename to mojo/package_manager/content_handler_connection.cc
index 34ae9a9ba1f50a739898997dae6891e75cf3384b..e778c4d09befd05c951b365b572a0fd504e21f8b 100644
--- a/mojo/shell/content_handler_connection.cc
+++ b/mojo/package_manager/content_handler_connection.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "mojo/shell/content_handler_connection.h"
+#include "mojo/package_manager/content_handler_connection.h"
#include "base/memory/scoped_ptr.h"
#include "mojo/shell/application_manager.h"
@@ -10,20 +10,22 @@
#include "mojo/shell/identity.h"
namespace mojo {
-namespace shell {
+namespace package_manager {
ContentHandlerConnection::ContentHandlerConnection(
- ApplicationManager* manager,
- const Identity& source,
- const Identity& content_handler,
- uint32_t id)
- : manager_(manager),
+ shell::ApplicationManager* manager,
+ const shell::Identity& source,
+ const shell::Identity& content_handler,
+ uint32_t id,
+ const ClosedCallback& connection_closed_callback)
+ : connection_closed_callback_(connection_closed_callback),
identity_(content_handler),
connection_closed_(false),
id_(id) {
ServiceProviderPtr services;
- scoped_ptr<ConnectToApplicationParams> params(new ConnectToApplicationParams);
+ scoped_ptr<shell::ConnectToApplicationParams> params(
+ new shell::ConnectToApplicationParams);
params->set_source(source);
params->SetTarget(identity_);
params->set_services(GetProxy(&services));
@@ -41,7 +43,7 @@ void ContentHandlerConnection::CloseConnection() {
if (connection_closed_)
return;
connection_closed_ = true;
- manager_->OnContentHandlerConnectionClosed(this);
+ connection_closed_callback_.Run(this);
delete this;
}
@@ -51,5 +53,5 @@ ContentHandlerConnection::~ContentHandlerConnection() {
DCHECK(connection_closed_);
}
-} // namespace shell
+} // namespace package_manager
} // namespace mojo
« no previous file with comments | « mojo/package_manager/content_handler_connection.h ('k') | mojo/package_manager/content_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698