tests/sel_main_chrome/sel_main_chrome_test.cc - Issue 135853021: NaCl: Expose NaClApp to embedding layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/sel_main_chrome/sel_main_chrome_test.cc

Issue 135853021: NaCl: Expose NaClApp to embedding layer. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master

Patch Set: Update test also Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/sel_main_chrome/sel_main_chrome_test.cc

diff --git a/tests/sel_main_chrome/sel_main_chrome_test.cc b/tests/sel_main_chrome/sel_main_chrome_test.cc

index b3092e06e4809f0e15ea72ee4df8893175c71371..be5dbddcab516e3b68549c41ce9c9e64cf8b44c2 100644

--- a/tests/sel_main_chrome/sel_main_chrome_test.cc

+++ b/tests/sel_main_chrome/sel_main_chrome_test.cc

@@ -135,7 +135,8 @@ int main(int argc, char **argv) {

CHECK(NaClThreadCtor(&thread, DummyRendererThread, &thread_args,

NACL_KERN_STACK_SIZE));

- NaClChromeMainStart(args);

+ struct NaClApp *nap = NaClAppCreate();

dmichael (off chromium) 2014/01/16 21:30:26 Here too... can you just do it on the stack?

+ NaClChromeMainStartApp(nap, args);

NaClLog(LOG_FATAL, "NaClChromeMainStart() should never return\n");

return 1;

}

« src/trusted/service_runtime/sel_main_chrome.c ('K') | « src/trusted/service_runtime/sel_main_chrome.c ('k') | no next file » | no next file with comments »