Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 135853011: Add coreutils (Closed)

Created:
6 years, 11 months ago by hamaji
Modified:
6 years, 11 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Add coreutils TEST=./make_all.sh coreutils TEST=cp -r out/publish/coreutils-8.22/glibc/{*.nexe,*.nmf,lib64} \ out/publish/bash-4.2/glibc/bash # and bash can spawn ls. R=sbc@chromium.org Committed: https://code.google.com/p/naclports/source/detail?r=1058

Patch Set 1 #

Total comments: 4

Patch Set 2 : add comments for the patch #

Patch Set 3 : update the comment for mempcpy #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -0 lines) Patch
M Makefile View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
A ports/coreutils/build.sh View 1 2 3 1 chunk +138 lines, -0 lines 0 comments Download
A ports/coreutils/coreutils-8.22.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A ports/coreutils/nacl.patch View 1 2 1 chunk +140 lines, -0 lines 0 comments Download
A ports/coreutils/pkg_info View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
hamaji
6 years, 11 months ago (2014-01-15 07:31:38 UTC) #1
Sam Clegg
lgtm https://codereview.chromium.org/135853011/diff/1/ports/coreutils/nacl.patch File ports/coreutils/nacl.patch (right): https://codereview.chromium.org/135853011/diff/1/ports/coreutils/nacl.patch#newcode9 ports/coreutils/nacl.patch:9: - src/libstdbuf.so$(EXEEXT) src/nice$(EXEEXT) src/pinky$(EXEEXT) \ Is this an ...
6 years, 11 months ago (2014-01-15 16:48:39 UTC) #2
hamaji
https://codereview.chromium.org/135853011/diff/1/ports/coreutils/nacl.patch File ports/coreutils/nacl.patch (right): https://codereview.chromium.org/135853011/diff/1/ports/coreutils/nacl.patch#newcode9 ports/coreutils/nacl.patch:9: - src/libstdbuf.so$(EXEEXT) src/nice$(EXEEXT) src/pinky$(EXEEXT) \ On 2014/01/15 16:48:39, Sam ...
6 years, 11 months ago (2014-01-16 05:43:45 UTC) #3
hamaji
I have rebased my change but it seems update_mirror.py failed again. I went to the ...
6 years, 11 months ago (2014-01-17 17:04:20 UTC) #4
Sam Clegg
On 2014/01/17 17:04:20, hamaji wrote: > I have rebased my change but it seems update_mirror.py ...
6 years, 11 months ago (2014-01-17 17:50:40 UTC) #5
hamaji
On 2014/01/17 17:50:40, Sam Clegg wrote: > On 2014/01/17 17:04:20, hamaji wrote: > > I ...
6 years, 11 months ago (2014-01-17 18:33:05 UTC) #6
Sam Clegg
+bradnelson to sort out boto access for you.
6 years, 11 months ago (2014-01-18 00:22:07 UTC) #7
bradn
Hi Hamaji, I've given you access on your account. Please let me know if you ...
6 years, 11 months ago (2014-01-18 00:44:37 UTC) #8
hamaji
Committed patchset #4 manually as r1058 (presubmit successful).
6 years, 11 months ago (2014-01-18 02:09:37 UTC) #9
hamaji
6 years, 11 months ago (2014-01-18 02:11:02 UTC) #10
Message was sent while issue was closed.
Yes, it worked, thanks!

Powered by Google App Engine
This is Rietveld 408576698