Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 135853010: Fix the WebStrings leak in MockWebClipboardImpl (Closed)

Created:
6 years, 11 months ago by yoichio
Modified:
6 years, 10 months ago
Reviewers:
sky, dcheng
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix the WebString leak in MockWebClipboardImpl When we run content_shell in the single process mode with tests using the clipboard, the renderer thread passes WebString to the browser thread. It causes leak. To avoid this, change the member WebString to NullableString16. BUG=328158 TEST=content_shell --dump-render-tree --single-process ../../third_party/WebKit/LayoutTests/editing/pasteboard/createMarkup-assert.xml Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247850

Patch Set 1 : copy string #

Total comments: 1

Patch Set 2 : Use NullableString16 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M content/test/mock_webclipboard_impl.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M content/test/mock_webclipboard_impl.cc View 1 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
yoichio
Could you review?
6 years, 11 months ago (2014-01-27 02:21:59 UTC) #1
dcheng
https://codereview.chromium.org/135853010/diff/160001/content/test/mock_webclipboard_impl.cc File content/test/mock_webclipboard_impl.cc (right): https://codereview.chromium.org/135853010/diff/160001/content/test/mock_webclipboard_impl.cc#newcode42 content/test/mock_webclipboard_impl.cc:42: return !m_plainText.empty(); The difference between empty and null is ...
6 years, 11 months ago (2014-01-27 19:47:04 UTC) #2
yoichio
Nice suggest! NullableString16 fits this issue. Thanks.
6 years, 11 months ago (2014-01-28 07:57:21 UTC) #3
dcheng
lgtm
6 years, 10 months ago (2014-01-28 23:42:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/135853010/200001
6 years, 10 months ago (2014-01-28 23:48:18 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=46871
6 years, 10 months ago (2014-01-29 00:09:25 UTC) #6
yoichio
+sky@ as an OWNER. Could you look?
6 years, 10 months ago (2014-01-29 01:38:02 UTC) #7
sky
LGTM
6 years, 10 months ago (2014-01-29 16:43:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/135853010/200001
6 years, 10 months ago (2014-01-29 22:42:59 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 06:19:47 UTC) #10
Message was sent while issue was closed.
Change committed as 247850

Powered by Google App Engine
This is Rietveld 408576698