Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: apps/app_shim/app_shim_mac.cc

Issue 135853008: Don't enable app shims in tests. (Mac) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add comment Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apps/app_shim/app_shim_mac.cc
diff --git a/apps/app_shim/app_shim_mac.cc b/apps/app_shim/app_shim_mac.cc
index becce615ba21e392443e8d3cce8143fdd45d1a10..a809fa74e58e1532a070c461e2135ce31b6fd80f 100644
--- a/apps/app_shim/app_shim_mac.cc
+++ b/apps/app_shim/app_shim_mac.cc
@@ -10,8 +10,10 @@
namespace apps {
bool IsAppShimsEnabled() {
- return !CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kDisableAppShims);
+ // Disable app shims in tests because shims created in ~/Applications will not
+ // be cleaned up.
+ return !(CommandLine::ForCurrentProcess()->HasSwitch(switches::kTestType) ||
+ CommandLine::ForCurrentProcess()->HasSwitch(switches::kDisableAppShims));
}
} // namespace apps
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698