Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 135853005: Minor optimization of SVG <textPath> layout (Closed)

Created:
6 years, 11 months ago by fs
Modified:
6 years, 11 months ago
CC:
blink-reviews, krit, bemjb+rendering_chromium.org, zoltan1, eae+blinkwatch, leviw+renderwatch, f(malita), jchaffraix+rendering, pdr, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Minor optimization of SVG <textPath> layout Path::pointAtLength and Path::normalAngleAtLength both call Path::pointAndNormalAtLength to do the work. SVGTextLayoutEngine::layoutTextOnLineOrPath call the two former, which means it'll setup and process the path twice. Change the two calls into one call to pointAndNormalAtLength to reduce the work required. BUG=135310 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165078

Patch Set 1 #

Patch Set 2 : Reupload. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M Source/core/rendering/svg/SVGTextLayoutEngine.cpp View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
fs
6 years, 11 months ago (2014-01-14 14:10:26 UTC) #1
Stephen Chennney
Looks like an upload error with a missing base. Could you upload again?
6 years, 11 months ago (2014-01-14 14:12:17 UTC) #2
Stephen Chennney
LGTM. From the email I can see this is good, and I am a bit ...
6 years, 11 months ago (2014-01-14 14:15:08 UTC) #3
fs
On 2014/01/14 14:12:17, Stephen Chenney wrote: > Looks like an upload error with a missing ...
6 years, 11 months ago (2014-01-14 15:20:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/135853005/80001
6 years, 11 months ago (2014-01-14 15:21:14 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-14 16:36:41 UTC) #6
Message was sent while issue was closed.
Change committed as 165078

Powered by Google App Engine
This is Rietveld 408576698