Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 1358503005: Use glibc's sigaction unless we are building for nonsfi nacl. (Closed)

Created:
5 years, 3 months ago by rickyz (no longer on Chrome)
Modified:
5 years, 3 months ago
Reviewers:
mdempsky
CC:
chromium-reviews, jln+watch_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use glibc's sigaction unless we are building for nonsfi nacl. BUG=532180 Committed: https://crrev.com/fd3ffac4f3421662e5e9700a7b7fa0d4330e1432 Cr-Commit-Position: refs/heads/master@{#350260}

Patch Set 1 #

Patch Set 2 : Add a TODO for nonsfi nacl unwinding #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -32 lines) Patch
M sandbox/linux/services/syscall_wrappers.cc View 1 2 chunks +6 lines, -32 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
rickyz (no longer on Chrome)
For now, the unwinding issues may still exist on nonsfi nacl builds, but this should ...
5 years, 3 months ago (2015-09-22 10:32:15 UTC) #2
mdempsky
LGTM assuming it fixes krasin@'s failing test scenario. ACK that the OS_NACL_NONSFI case might still ...
5 years, 3 months ago (2015-09-22 10:52:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358503005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358503005/20001
5 years, 3 months ago (2015-09-22 21:29:58 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-22 23:23:35 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 23:24:25 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fd3ffac4f3421662e5e9700a7b7fa0d4330e1432
Cr-Commit-Position: refs/heads/master@{#350260}

Powered by Google App Engine
This is Rietveld 408576698