Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 1358433003: MD Settings: Make PolicyControllable behavior for isPolicyControlled() (Closed)

Created:
5 years, 3 months ago by michaelpg
Modified:
5 years, 3 months ago
Reviewers:
stevenjb, Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org, jhawkins+watch-md-settings_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Make PolicyControllable behavior for isControlled() This will let us add an isPolicyControlled() method to any Polymer element with an associated pref. BUG=521791 R=stevenjb@chromium.org,dbeam@chromium.org Committed: https://crrev.com/3a91c55c3110879032376122b9f0e8f06efe54a4 Cr-Commit-Position: refs/heads/master@{#350105}

Patch Set 1 #

Total comments: 4

Patch Set 2 : isPolicyControlled() #

Patch Set 3 : i have brought great shame upon us #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -4 lines) Patch
M chrome/browser/resources/settings/checkbox/checkbox.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/checkbox/checkbox.js View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/checkbox/compiled_resources.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/browser/resources/settings/policy_controllable/policy_controllable.html View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/resources/settings/policy_controllable/policy_controllable.js View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/web_dev_style/js_checker.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
michaelpg
Our first behavior! WDYT?
5 years, 3 months ago (2015-09-20 21:07:18 UTC) #1
stevenjb
Nice. lgtm w/ naming suggestion. https://codereview.chromium.org/1358433003/diff/1/chrome/browser/resources/settings/policy_controllable/policy_controllable.js File chrome/browser/resources/settings/policy_controllable/policy_controllable.js (right): https://codereview.chromium.org/1358433003/diff/1/chrome/browser/resources/settings/policy_controllable/policy_controllable.js#newcode11 chrome/browser/resources/settings/policy_controllable/policy_controllable.js:11: isControlled: function(pref) { nit: ...
5 years, 3 months ago (2015-09-21 20:41:43 UTC) #2
Dan Beam
lgtm https://codereview.chromium.org/1358433003/diff/1/chrome/browser/resources/settings/policy_controllable/policy_controllable.js File chrome/browser/resources/settings/policy_controllable/policy_controllable.js (right): https://codereview.chromium.org/1358433003/diff/1/chrome/browser/resources/settings/policy_controllable/policy_controllable.js#newcode11 chrome/browser/resources/settings/policy_controllable/policy_controllable.js:11: isControlled: function(pref) { On 2015/09/21 20:41:43, stevenjb wrote: ...
5 years, 3 months ago (2015-09-21 22:27:11 UTC) #3
michaelpg
https://codereview.chromium.org/1358433003/diff/1/chrome/browser/resources/settings/policy_controllable/policy_controllable.js File chrome/browser/resources/settings/policy_controllable/policy_controllable.js (right): https://codereview.chromium.org/1358433003/diff/1/chrome/browser/resources/settings/policy_controllable/policy_controllable.js#newcode11 chrome/browser/resources/settings/policy_controllable/policy_controllable.js:11: isControlled: function(pref) { On 2015/09/21 20:41:43, stevenjb wrote: > ...
5 years, 3 months ago (2015-09-22 02:22:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358433003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358433003/20001
5 years, 3 months ago (2015-09-22 02:23:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/102329)
5 years, 3 months ago (2015-09-22 02:34:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358433003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358433003/40001
5 years, 3 months ago (2015-09-22 02:41:25 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/105993)
5 years, 3 months ago (2015-09-22 03:43:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358433003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358433003/40001
5 years, 3 months ago (2015-09-22 03:46:17 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-22 04:16:11 UTC) #17
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 04:16:51 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3a91c55c3110879032376122b9f0e8f06efe54a4
Cr-Commit-Position: refs/heads/master@{#350105}

Powered by Google App Engine
This is Rietveld 408576698