Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: Source/bindings/v8/custom/V8WindowCustom.cpp

Issue 135843008: Remove V8HiddenPropertyName (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/custom/V8WindowCustom.cpp
diff --git a/Source/bindings/v8/custom/V8WindowCustom.cpp b/Source/bindings/v8/custom/V8WindowCustom.cpp
index c48591da29c0d977207b8e5c135c7e3115fd4161..5891cf37ec9b9c5b0ddc19e2614b70ef95f5e866 100644
--- a/Source/bindings/v8/custom/V8WindowCustom.cpp
+++ b/Source/bindings/v8/custom/V8WindowCustom.cpp
@@ -44,7 +44,6 @@
#include "bindings/v8/V8EventListener.h"
#include "bindings/v8/V8EventListenerList.h"
#include "bindings/v8/V8GCForContextDispose.h"
-#include "bindings/v8/V8HiddenPropertyName.h"
#include "bindings/v8/V8Utilities.h"
#include "core/dom/ExceptionCode.h"
#include "core/dom/MessagePort.h"
@@ -163,8 +162,7 @@ void V8Window::eventAttributeGetterCustom(const v8::PropertyCallbackInfo<v8::Val
if (context.IsEmpty())
return;
- v8::Handle<v8::String> eventSymbol = V8HiddenPropertyName::event(info.GetIsolate());
- v8::Handle<v8::Value> jsEvent = context->Global()->GetHiddenValue(eventSymbol);
+ v8::Handle<v8::Value> jsEvent = getHiddenValue(info.GetIsolate(), context->Global(), "event");
if (jsEvent.IsEmpty())
return;
v8SetReturnValue(info, jsEvent);
@@ -184,8 +182,7 @@ void V8Window::eventAttributeSetterCustom(v8::Local<v8::Value> value, const v8::
if (context.IsEmpty())
return;
- v8::Handle<v8::String> eventSymbol = V8HiddenPropertyName::event(info.GetIsolate());
- context->Global()->SetHiddenValue(eventSymbol, value);
+ setHiddenValue(info.GetIsolate(), context->Global(), "event", value);
}
void V8Window::frameElementAttributeGetterCustom(const v8::PropertyCallbackInfo<v8::Value>& info)
« no previous file with comments | « Source/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698