Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: Source/bindings/v8/custom/V8HistoryCustom.cpp

Issue 135843008: Remove V8HiddenPropertyName (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/custom/V8HistoryCustom.cpp
diff --git a/Source/bindings/v8/custom/V8HistoryCustom.cpp b/Source/bindings/v8/custom/V8HistoryCustom.cpp
index bf04305e15cfdca8322071998d37b6df56acc270..c9e2b8888a5fa0e844a941a9ae238609ff471d15 100644
--- a/Source/bindings/v8/custom/V8HistoryCustom.cpp
+++ b/Source/bindings/v8/custom/V8HistoryCustom.cpp
@@ -35,7 +35,6 @@
#include "bindings/v8/ExceptionState.h"
#include "bindings/v8/SerializedScriptValue.h"
#include "bindings/v8/V8Binding.h"
-#include "bindings/v8/V8HiddenPropertyName.h"
#include "core/dom/ExceptionCode.h"
#include "core/frame/History.h"
@@ -45,7 +44,7 @@ void V8History::stateAttributeGetterCustom(const v8::PropertyCallbackInfo<v8::Va
{
History* history = V8History::toNative(info.Holder());
- v8::Handle<v8::Value> value = info.Holder()->GetHiddenValue(V8HiddenPropertyName::state(info.GetIsolate()));
+ v8::Handle<v8::Value> value = getHiddenValue(info.GetIsolate(), info.Holder(), "state");
if (!value.IsEmpty() && !history->stateChanged()) {
v8SetReturnValue(info, value);
@@ -54,7 +53,7 @@ void V8History::stateAttributeGetterCustom(const v8::PropertyCallbackInfo<v8::Va
RefPtr<SerializedScriptValue> serialized = history->state();
value = serialized ? serialized->deserialize(info.GetIsolate()) : v8::Handle<v8::Value>(v8::Null(info.GetIsolate()));
- info.Holder()->SetHiddenValue(V8HiddenPropertyName::state(info.GetIsolate()), value);
+ setHiddenValue(info.GetIsolate(), info.Holder(), "state", value);
v8SetReturnValue(info, value);
}
@@ -71,7 +70,7 @@ void V8History::pushStateMethodCustom(const v8::FunctionCallbackInfo<v8::Value>&
History* history = V8History::toNative(info.Holder());
history->stateObjectAdded(historyState.release(), title, url, SameDocumentNavigationPushState, exceptionState);
- info.Holder()->DeleteHiddenValue(V8HiddenPropertyName::state(info.GetIsolate()));
+ deleteHiddenValue(info.GetIsolate(), info.Holder(), "state");
exceptionState.throwIfNeeded();
}
@@ -87,7 +86,7 @@ void V8History::replaceStateMethodCustom(const v8::FunctionCallbackInfo<v8::Valu
History* history = V8History::toNative(info.Holder());
history->stateObjectAdded(historyState.release(), title, url, SameDocumentNavigationReplaceState, exceptionState);
- info.Holder()->DeleteHiddenValue(V8HiddenPropertyName::state(info.GetIsolate()));
+ deleteHiddenValue(info.GetIsolate(), info.Holder(), "state");
exceptionState.throwIfNeeded();
}
« no previous file with comments | « Source/bindings/v8/custom/V8ErrorEventCustom.cpp ('k') | Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698