Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: Source/bindings/v8/ScriptState.cpp

Issue 135843008: Remove V8HiddenPropertyName (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/ScriptController.cpp ('k') | Source/bindings/v8/V8AbstractEventListener.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/ScriptState.cpp
diff --git a/Source/bindings/v8/ScriptState.cpp b/Source/bindings/v8/ScriptState.cpp
index 0eda05f2ce68ef328d14846addc03e361ad20308..4796a0061c02701be803796c7a39f71978515cd9 100644
--- a/Source/bindings/v8/ScriptState.cpp
+++ b/Source/bindings/v8/ScriptState.cpp
@@ -34,7 +34,6 @@
#include "V8Window.h"
#include "V8WorkerGlobalScope.h"
#include "bindings/v8/ScriptController.h"
-#include "bindings/v8/V8HiddenPropertyName.h"
#include "bindings/v8/WorkerScriptController.h"
#include "core/frame/Frame.h"
#include "core/workers/WorkerGlobalScope.h"
@@ -72,12 +71,12 @@ ScriptState* ScriptState::forContext(v8::Handle<v8::Context> context)
v8::Local<v8::Object> innerGlobal = v8::Local<v8::Object>::Cast(context->Global()->GetPrototype());
- v8::Local<v8::Value> scriptStateWrapper = innerGlobal->GetHiddenValue(V8HiddenPropertyName::scriptState(context->GetIsolate()));
+ v8::Local<v8::Value> scriptStateWrapper = getHiddenValue(context->GetIsolate(), innerGlobal, "scriptState");
if (!scriptStateWrapper.IsEmpty() && scriptStateWrapper->IsExternal())
return static_cast<ScriptState*>(v8::External::Cast(*scriptStateWrapper)->Value());
ScriptState* scriptState = new ScriptState(context);
- innerGlobal->SetHiddenValue(V8HiddenPropertyName::scriptState(context->GetIsolate()), v8::External::New(context->GetIsolate(), scriptState));
+ setHiddenValue(context->GetIsolate(), innerGlobal, "scriptState", v8::External::New(context->GetIsolate(), scriptState));
return scriptState;
}
« no previous file with comments | « Source/bindings/v8/ScriptController.cpp ('k') | Source/bindings/v8/V8AbstractEventListener.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698