Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: Source/bindings/tests/results/V8TestObject.cpp

Issue 135843008: Remove V8HiddenPropertyName (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestObject.cpp
diff --git a/Source/bindings/tests/results/V8TestObject.cpp b/Source/bindings/tests/results/V8TestObject.cpp
index e95c478c9cf7b88f20fe3ae3267cd75eca6f6b78..715636534015d556821947951c27b2e772a339a2 100644
--- a/Source/bindings/tests/results/V8TestObject.cpp
+++ b/Source/bindings/tests/results/V8TestObject.cpp
@@ -56,7 +56,6 @@
#include "bindings/v8/V8DOMActivityLogger.h"
#include "bindings/v8/V8DOMConfiguration.h"
#include "bindings/v8/V8EventListenerList.h"
-#include "bindings/v8/V8HiddenPropertyName.h"
#include "bindings/v8/V8ObjectConstructor.h"
#include "bindings/v8/custom/V8Float32ArrayCustom.h"
#include "core/css/MediaQueryListListener.h"
@@ -131,7 +130,7 @@ static void readOnlyTestObjectAttrAttributeGetter(const v8::PropertyCallbackInfo
return;
v8::Handle<v8::Value> wrapper = toV8(result.get(), info.Holder(), info.GetIsolate());
if (!wrapper.IsEmpty()) {
- V8HiddenPropertyName::setNamedHiddenReference(info.Holder(), "readOnlyTestObjectAttr", wrapper);
+ setHiddenValue(info.Holder(), v8AtomicString(info.GetIsolate(), "readOnlyTestObjectAttr"), wrapper);
v8SetReturnValue(info, wrapper);
}
}
@@ -2247,14 +2246,14 @@ static void cachedDirtyableAttributeAttributeGetter(const v8::PropertyCallbackIn
v8::Handle<v8::String> propertyName = v8AtomicString(info.GetIsolate(), "cachedDirtyableAttribute");
TestObj* imp = V8TestObject::toNative(info.Holder());
if (!imp->isValueDirty()) {
- v8::Handle<v8::Value> jsValue = info.Holder()->GetHiddenValue(propertyName);
+ v8::Handle<v8::Value> jsValue = getHiddenValue(info.Holder(), propertyName);
if (!jsValue.IsEmpty()) {
v8SetReturnValue(info, jsValue);
return;
}
}
ScriptValue jsValue = imp->cachedDirtyableAttribute();
- info.Holder()->SetHiddenValue(propertyName, jsValue.v8Value());
+ setHiddenValue(info.Holder(), propertyName, jsValue.v8Value());
v8SetReturnValue(info, jsValue.v8Value());
}
@@ -2270,7 +2269,7 @@ static void cachedDirtyableAttributeRaisesAttributeGetter(const v8::PropertyCall
v8::Handle<v8::String> propertyName = v8AtomicString(info.GetIsolate(), "cachedDirtyableAttributeRaises");
TestObj* imp = V8TestObject::toNative(info.Holder());
if (!imp->isValueDirty()) {
- v8::Handle<v8::Value> jsValue = info.Holder()->GetHiddenValue(propertyName);
+ v8::Handle<v8::Value> jsValue = getHiddenValue(info.Holder(), propertyName);
if (!jsValue.IsEmpty()) {
v8SetReturnValue(info, jsValue);
return;
@@ -2280,7 +2279,7 @@ static void cachedDirtyableAttributeRaisesAttributeGetter(const v8::PropertyCall
ScriptValue jsValue = imp->cachedDirtyableAttributeRaises(exceptionState);
if (UNLIKELY(exceptionState.throwIfNeeded()))
return;
- info.Holder()->SetHiddenValue(propertyName, jsValue.v8Value());
+ setHiddenValue(info.Holder(), propertyName, jsValue.v8Value());
v8SetReturnValue(info, jsValue.v8Value());
}
@@ -2724,7 +2723,7 @@ static void perWorldReadOnlyAttributeAttributeGetter(const v8::PropertyCallbackI
return;
v8::Handle<v8::Value> wrapper = toV8(result.get(), info.Holder(), info.GetIsolate());
if (!wrapper.IsEmpty()) {
- V8HiddenPropertyName::setNamedHiddenReference(info.Holder(), "perWorldReadOnlyAttribute", wrapper);
+ setHiddenValue(info.Holder(), v8AtomicString(info.GetIsolate(), "perWorldReadOnlyAttribute"), wrapper);
v8SetReturnValue(info, wrapper);
}
}
@@ -2744,7 +2743,7 @@ static void perWorldReadOnlyAttributeAttributeGetterForMainWorld(const v8::Prope
return;
v8::Handle<v8::Value> wrapper = toV8(result.get(), info.Holder(), info.GetIsolate());
if (!wrapper.IsEmpty()) {
- V8HiddenPropertyName::setNamedHiddenReference(info.Holder(), "perWorldReadOnlyAttribute", wrapper);
+ setHiddenValue(info.Holder(), v8AtomicString(info.GetIsolate(), "perWorldReadOnlyAttribute"), wrapper);
v8SetReturnValue(info, wrapper);
}
}

Powered by Google App Engine
This is Rietveld 408576698