Remove V8HiddenPropertyName

Source/bindings/scripts/code_generator_v8.pm

 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
 # Copyright (C) 2006 Apple Computer, Inc.
 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
 # Copyright (C) 2012 Ericsson AB. All rights reserved.
@@ skipping 1246 matching lines @@
         return;
     }
     ${implClassName}* imp = ${v8ClassName}::toNative(holder);
     if (!BindingSecurity::shouldAllowAccessToFrame(imp->frame(), DoNotReportSecurityError)) {
         static int sharedTemplateUniqueKey;
         v8::Handle<v8::FunctionTemplate> sharedTemplate = data->privateTemplate(currentWorldType, &sharedTemplateUniqueKey, $newTemplateParams, $functionLength);
         v8SetReturnValue(info, sharedTemplate->GetFunction());
         return;
     }
 
-    v8::Local<v8::Value> hiddenValue = info.This()->GetHiddenValue(v8AtomicString(info.GetIsolate(), "${funcName}"));
+    v8::Local<v8::Value> hiddenValue = getHiddenValue(info.GetIsolate(), info.This(), "${funcName}");
     if (!hiddenValue.IsEmpty()) {
         v8SetReturnValue(info, hiddenValue);
         return;
     }
 
     v8SetReturnValue(info, privateTemplate->GetFunction());
 }
 
 END
     $implementation{nameSpaceInternal}->add(<<END);
@@ skipping 23 matching lines @@
     if (holder.IsEmpty())
         return;
     ${implClassName}* imp = ${v8ClassName}::toNative(holder);
     v8::String::Utf8Value attributeName(name);
     ExceptionState exceptionState(ExceptionState::SetterContext, *attributeName, "${interfaceName}", info.Holder(), info.GetIsolate());
     if (!BindingSecurity::shouldAllowAccessToFrame(imp->frame(), exceptionState)) {
         exceptionState.throwIfNeeded();
         return;
     }
 
-    info.This()->SetHiddenValue(name, jsValue);
+    setHiddenValue(info.GetIsolate(), info.This(), name, jsValue);
 }
 
 static void ${implClassName}OriginSafeMethodSetterCallback(v8::Local<v8::String> name, v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)
 {
     TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMSetter");
     ${implClassName}V8Internal::${implClassName}OriginSafeMethodSetter(name, jsValue, info);
     TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
 }
 
 END
@@ skipping 213 matching lines @@
             return;
             # Skip the rest of the function!
         }
         my $imp = 0;
         if ($attrCached) {
             $imp = 1;
             $code .= <<END;
     v8::Handle<v8::String> propertyName = v8AtomicString(info.GetIsolate(), "${attrName}");
     ${implClassName}* imp = ${v8ClassName}::toNative(info.Holder());
     if (!imp->$attrCached()) {
-        v8::Handle<v8::Value> jsValue = info.Holder()->GetHiddenValue(propertyName);
+        v8::Handle<v8::Value> jsValue = getHiddenValue(info.GetIsolate(), info.Holder(), propertyName);
         if (!jsValue.IsEmpty()) {
             v8SetReturnValue(info, jsValue);
             return;
         }
     }
 END
         }
         if (!$attribute->isStatic && !$imp) {
             $code .= <<END;
     ${implClassName}* imp = ${v8ClassName}::toNative(info.Holder());
@@ skipping 88 matching lines @@
 
     if (ShouldKeepAttributeAlive($interface, $attribute, $attrType)) {
         my $arrayType = GetArrayType($attrType);
         if ($arrayType) {
             $code .= "    v8SetReturnValue(info, v8Array(${getterString}, info.GetIsolate()));\n";
             $code .= "}\n\n";
             $implementation{nameSpaceInternal}->add($code);
             return;
         }
 
-        AddToImplIncludes("bindings/v8/V8HiddenPropertyName.h");
         # Check for a wrapper in the wrapper cache. If there is one, we know that a hidden reference has already
         # been created. If we don't find a wrapper, we create both a wrapper and a hidden reference.
         my $nativeReturnType = GetNativeType($attrType);
         my $v8ReturnType = "V8" . $attrType;
         $code .= "    $nativeReturnType result = ${getterString};\n";
         if ($forMainWorldSuffix) {
             $code .= "    if (result && DOMDataStore::setReturnValueFromWrapper${forMainWorldSuffix}<${v8ReturnType}>(info.GetReturnValue(), result.get()))\n";
         } else {
             $code .= "    if (result && DOMDataStore::setReturnValueFromWrapper<${v8ReturnType}>(info.GetReturnValue(), result.get()))\n";
         }
         $code .= "        return;\n";
         $code .= "    v8::Handle<v8::Value> wrapper = toV8(result.get(), info.Holder(), info.GetIsolate());\n";
         $code .= "    if (!wrapper.IsEmpty()) {\n";
-        $code .= "        V8HiddenPropertyName::setNamedHiddenReference(info.Holder(), \"${attrName}\", wrapper);\n";
+        $code .= "        setHiddenValue(info.GetIsolate(), info.Holder(), \"${attrName}\", wrapper);\n";
         $code .= "        v8SetReturnValue(info, wrapper);\n";
         $code .= "    }\n";
         $code .= "}\n";
         $code .= "#endif // ${conditionalString}\n" if $conditionalString;
         $code .= "\n";
         $implementation{nameSpaceInternal}->add($code);
         return;
     }
 
     if ((IsSVGAnimatedType($interfaceName) or $interfaceName eq "SVGViewSpec") and IsSVGTypeNeedingTearOff($attrType)) {
@@ skipping 38 matching lines @@
         if ($forMainWorldSuffix eq "ForMainWorld") {
             $code .= "    v8SetReturnValueForMainWorld(info, $wrappedValue);\n";
         } else {
             $code .= "    v8SetReturnValueFast(info, $wrappedValue, imp);\n";
         }
     } elsif ($attrCached) {
         if ($attribute->type eq "SerializedScriptValue") {
         $code .= <<END;
     RefPtr<SerializedScriptValue> serialized = $getterString;
     ScriptValue jsValue = serialized ? serialized->deserialize() : v8::Handle<v8::Value>(v8::Null(info.GetIsolate()));
-    info.Holder()->SetHiddenValue(propertyName, jsValue);
+    setHiddenValue(info.GetIsolate(), info.Holder(), propertyName, jsValue);
     v8SetReturnValue(info, jsValue);
 END
         } else {
             if (!$useExceptions && !$isNullable) {
                 $code .= <<END;
     ScriptValue jsValue = $getterString;
 END
             }
             $code .= <<END;
-    info.Holder()->SetHiddenValue(propertyName, jsValue.v8Value());
+    setHiddenValue(info.GetIsolate(), info.Holder(), propertyName, jsValue.v8Value());
     v8SetReturnValue(info, jsValue.v8Value());
 END
         }
     } elsif ($attribute->type eq "EventHandler") {
         AddToImplIncludes("bindings/v8/V8AbstractEventListener.h");
         # FIXME: Pass the main world ID for main-world-only getters.
         my ($functionName, @arguments) = GetterExpression($interfaceName, $attribute);
         my $implementedBy = $attribute->extendedAttributes->{"ImplementedBy"};
         if ($implementedBy) {
             my $implementedByImplName = GetImplNameFromImplementedBy($implementedBy);
@@ skipping 406 matching lines @@
         if ($useExceptions) {
             $code .= "    if (!exceptionState.hadException())\n";
             $code .= "        wrapper->commitChange();\n";
         } else {
             $code .= "    wrapper->commitChange();\n";
         }
     }
 
     if ($attrCached) {
         $code .= <<END;
-    info.Holder()->DeleteHiddenValue(v8AtomicString(info.GetIsolate(), "${attrName}")); // Invalidate the cached value.
+    deleteHiddenValue(info.GetIsolate(), info.Holder(), "${attrName}"); // Invalidate the cached value.
 END
     }
 
     $code .= "}\n";  # end of setter
     $code .= "#endif // ${conditionalString}\n" if $conditionalString;
     $code .= "\n";
     $implementation{nameSpaceInternal}->add($code);
 }
 
 sub GenerateParametersCheckExpression
@@ skipping 821 matching lines @@
             exceptionState.throwIfNeeded();
             return;
         }
 END
 
     # Store 'any'-typed properties on the wrapper to avoid leaking them between isolated worlds.
     foreach my $attrName (@anyAttributeNames) {
         $implementation{nameSpaceInternal}->add(<<END);
         options.get("${attrName}", ${attrName});
         if (!${attrName}.IsEmpty())
-            info.Holder()->SetHiddenValue(V8HiddenPropertyName::${attrName}(info.GetIsolate()), ${attrName});
+            setHiddenValue(info.GetIsolate(), info.Holder(), "${attrName}", ${attrName});
 END
     }
 
     $implementation{nameSpaceInternal}->add(<<END);
     }
 END
 
     my $exceptionStateArgument = "";
     if ($constructorRaisesException) {
         ${exceptionStateArgument} = ", exceptionState";
@@ skipping 3385 matching lines @@
         if ($parameter->type eq "SerializedScriptValue") {
             return 1;
         } elsif (IsIntegerType($parameter->type)) {
             return 1;
         }
     }
     return 0;
 }
 
 1;