Remove V8HiddenPropertyName

Source/bindings/v8/CustomElementConstructorBuilder.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 25 matching lines @@
 #include "V8Document.h"
 #include "V8HTMLElementWrapperFactory.h"
 #include "V8SVGElementWrapperFactory.h"
 #include "bindings/v8/CustomElementBinding.h"
 #include "bindings/v8/DOMWrapperWorld.h"
 #include "bindings/v8/Dictionary.h"
 #include "bindings/v8/ExceptionState.h"
 #include "bindings/v8/ScriptState.h"
 #include "bindings/v8/UnsafePersistent.h"
 #include "bindings/v8/V8Binding.h"
-#include "bindings/v8/V8HiddenPropertyName.h"
 #include "bindings/v8/V8PerContextData.h"
 #include "core/dom/Document.h"
 #include "core/dom/custom/CustomElementCallbackDispatcher.h"
 #include "core/dom/custom/CustomElementDefinition.h"
 #include "core/dom/custom/CustomElementDescriptor.h"
 #include "core/dom/custom/CustomElementException.h"
 #include "wtf/Assertions.h"
 
 namespace WebCore {
 
@@ skipping 127 matching lines @@
 
     v8::Handle<v8::String> v8TagName = v8String(isolate, descriptor.localName());
     v8::Handle<v8::Value> v8Type;
     if (descriptor.isTypeExtension())
         v8Type = v8String(isolate, descriptor.type());
     else
         v8Type = v8::Null(isolate);
 
     m_constructor->SetName(v8Type->IsNull() ? v8TagName : v8Type.As<v8::String>());
 
-    V8HiddenPropertyName::setNamedHiddenReference(m_constructor, "customElementDocument", toV8(document, m_context->Global(), isolate));
-    V8HiddenPropertyName::setNamedHiddenReference(m_constructor, "customElementNamespaceURI", v8String(isolate, descriptor.namespaceURI()));
-    V8HiddenPropertyName::setNamedHiddenReference(m_constructor, "customElementTagName", v8TagName);
-    V8HiddenPropertyName::setNamedHiddenReference(m_constructor, "customElementType", v8Type);
+    setHiddenValue(m_constructor, v8AtomicString(isolate, "customElementDocument"), toV8(document, m_context->Global(), isolate));
+    setHiddenValue(m_constructor, v8AtomicString(isolate, "customElementNamespaceURI"), v8String(isolate, descriptor.namespaceURI()));
+    setHiddenValue(m_constructor, v8AtomicString(isolate, "customElementTagName"), v8TagName);
+    setHiddenValue(m_constructor, v8AtomicString(isolate, "customElementType"), v8Type);
 
     v8::Handle<v8::String> prototypeKey = v8String(isolate, "prototype");
     ASSERT(m_constructor->HasOwnProperty(prototypeKey));
     // This sets the property *value*; calling Set is safe because
     // "prototype" is a non-configurable data property so there can be
     // no side effects.
     m_constructor->Set(prototypeKey, m_prototype);
     // This *configures* the property. ForceSet of a function's
     // "prototype" does not affect the value, but can reconfigure the
     // property.
     m_constructor->ForceSet(prototypeKey, m_prototype, v8::PropertyAttribute(v8::ReadOnly | v8::DontEnum | v8::DontDelete));
 
-    V8HiddenPropertyName::setNamedHiddenReference(m_prototype, "customElementIsInterfacePrototypeObject", v8::True(isolate));
+    setHiddenValue(m_prototype, v8AtomicString(isolate, "customElementIsInterfacePrototypeObject"), v8::True(isolate));
     m_prototype->ForceSet(v8String(isolate, "constructor"), m_constructor, v8::DontEnum);
 
     return true;
 }
 
 bool CustomElementConstructorBuilder::prototypeIsValid(const AtomicString& type, ExceptionState& exceptionState) const
 {
-    if (m_prototype->InternalFieldCount() || !m_prototype->GetHiddenValue(V8HiddenPropertyName::customElementIsInterfacePrototypeObject(m_context->GetIsolate())).IsEmpty()) {
+    if (m_prototype->InternalFieldCount() || !getHiddenValue(m_prototype, v8AtomicString(m_context->GetIsolate(), "customElementIsInterfacePrototypeObject")).IsEmpty()) {
         CustomElementException::throwException(CustomElementException::PrototypeInUse, type, exceptionState);
         return false;
     }
 
     if (m_prototype->GetPropertyAttributes(v8String(m_context->GetIsolate(), "constructor")) & v8::DontDelete) {
         CustomElementException::throwException(CustomElementException::ConstructorPropertyNotConfigurable, type, exceptionState);
         return false;
     }
 
     return true;
@@ skipping 34 matching lines @@
     if (!info.IsConstructCall()) {
         throwTypeError("DOM object constructor cannot be called as a function.", isolate);
         return;
     }
 
     if (info.Length() > 0) {
         throwTypeError("This constructor should be called without arguments.", isolate);
         return;
     }
 
-    Document* document = V8Document::toNative(info.Callee()->GetHiddenValue(V8HiddenPropertyName::customElementDocument(isolate)).As<v8::Object>());
-    V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, namespaceURI, info.Callee()->GetHiddenValue(V8HiddenPropertyName::customElementNamespaceURI(isolate)));
-    V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, tagName, info.Callee()->GetHiddenValue(V8HiddenPropertyName::customElementTagName(isolate)));
-    v8::Handle<v8::Value> maybeType = info.Callee()->GetHiddenValue(V8HiddenPropertyName::customElementType(isolate));
+    Document* document = V8Document::toNative(getHiddenValue(info.Callee(), v8AtomicString(isolate, "customElementDocument")).As<v8::Object>());
+    V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, namespaceURI, getHiddenValue(info.Callee(), v8AtomicString(isolate, "customElementNamespaceURI")));
+    V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, tagName, getHiddenValue(info.Callee(), v8AtomicString(isolate, "customElementTagName")));
+    v8::Handle<v8::Value> maybeType = getHiddenValue(info.Callee(), v8AtomicString(isolate, "customElementType"));
     V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, type, maybeType);
 
     ExceptionState exceptionState(ExceptionState::ConstructionContext, "CustomElement", info.Holder(), info.GetIsolate());
     CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
     RefPtr<Element> element = document->createElementNS(namespaceURI, tagName, maybeType->IsNull() ? nullAtom : type, exceptionState);
     if (exceptionState.throwIfNeeded())
         return;
     v8SetReturnValueFast(info, element.release(), document);
 }
 
 } // namespace WebCore