runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.dart - Issue 135843006: Improve Code object support in service and observatory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.dart

Issue 135843006: Improve Code object support in service and observatory (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_profile.html ('k') | runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.dart

diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.dart b/runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.dart

index 641d11f8eaf0197c44c572969d90cecafaee1424..1899e7c2fed89ed357686b5ac84264ec21e15719 100644

--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.dart

+++ b/runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.dart

@@ -4,6 +4,7 @@

library message_viewer_element;

+import 'package:logging/logging.dart';

import 'package:polymer/polymer.dart';

import 'observatory_element.dart';

@@ -16,6 +17,7 @@ class MessageViewerElement extends ObservatoryElement {

_message = m;

notifyPropertyChange(#messageType, "", messageType);

notifyPropertyChange(#members, [], members);

+ Logger.root.info('Viewing message of type \'${message['type']}\'');

}

MessageViewerElement.created() : super.created();

@@ -24,7 +26,6 @@ class MessageViewerElement extends ObservatoryElement {

if (message == null || message['type'] == null) {

return 'Error';

}

- print("Received message of type '${message['type']}' :\n$message");

return message['type'];

}