runtime/bin/vmservice/client/lib/src/observatory_elements/error_view.html - Issue 135843006: Improve Code object support in service and observatory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory_elements/error_view.html

Issue 135843006: Improve Code object support in service and observatory (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« runtime/bin/vmservice/client/lib/src/observatory/request_manager.dart ('K') | « runtime/bin/vmservice/client/lib/src/observatory_elements/error_view.dart ('k') | runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_profile.dart » ('j') | runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_profile.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/lib/src/observatory_elements/error_view.html

diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/error_view.html b/runtime/bin/vmservice/client/lib/src/observatory_elements/error_view.html

index db52e407693159d8aeef0ae0edd0810f911fcd44..336cc0c7e665dbd20a3deeed6eeb906741fa437e 100644

--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/error_view.html

+++ b/runtime/bin/vmservice/client/lib/src/observatory_elements/error_view.html

@@ -6,14 +6,9 @@

- <div class="panel-heading">Error</div>

+ <div class="panel-heading">{{ error['errorType'] }}</div>

- <template if="{{ (error_obj == null) || (error_obj['type'] != 'LanguageError') }}">

- <p>{{ error }}</p>

- </template>

- <template if="{{ (error_obj != null) && (error_obj['type'] == 'LanguageError') }}">

- <pre>{{ error_obj['error_msg'] }}</pre>

- </template>

+ <p>{{ error['text'] }}</p>

</div>