Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1629)

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory_elements/disassembly_entry.html

Issue 135843006: Improve Code object support in service and observatory (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/observatory_elements/disassembly_entry.html
diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/disassembly_entry.html b/runtime/bin/vmservice/client/lib/src/observatory_elements/disassembly_entry.html
index cc20dd7ab8b063c4427549397ea00919c9f1dd4f..0ab8fd896ec5a7856db508d7bb989666191c4e69 100644
--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/disassembly_entry.html
+++ b/runtime/bin/vmservice/client/lib/src/observatory_elements/disassembly_entry.html
@@ -4,18 +4,11 @@
<polymer-element name="disassembly-entry" extends="observatory-element">
<template>
<div class="row">
- <template if="{{ instruction['type'] == 'DisassembledInstructionComment' }}">
- <div class="col-md-2"></div>
- <div class="col-md-2"></div>
- <div class="col-md-4"><code>{{ instruction['comment'] }}</code></div>
- </template>
- <template if="{{ instruction['type'] == 'DisassembledInstruction' }}">
- <div class="col-md-2"></div>
- <div class="col-md-2">{{ instruction['pc'] }}</div>
+ <div class="col-md-2">{{ instruction.formattedTicks }}</div>
+ <div class="col-md-2">{{ instruction.formattedAddress() }}</div>
<div class="col-md-4">
- <code>{{ instruction['hex'] }} {{ instruction['human'] }}</code>
+ <code>{{ instruction.machine }} {{ instruction.human }}</code>
</div>
- </template>
</div>
</template>
<script type="application/dart" src="disassembly_entry.dart"></script>

Powered by Google App Engine
This is Rietveld 408576698