runtime/bin/vmservice/client/lib/src/observatory/isolate_manager.dart - Issue 135843006: Improve Code object support in service and observatory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory/isolate_manager.dart

Issue 135843006: Improve Code object support in service and observatory (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/client/lib/src/observatory/isolate.dart ('k') | runtime/bin/vmservice/client/lib/src/observatory/location_manager.dart » ('j') | runtime/bin/vmservice/client/lib/src/observatory/model.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/lib/src/observatory/isolate_manager.dart

diff --git a/runtime/bin/vmservice/client/lib/src/observatory/isolate_manager.dart b/runtime/bin/vmservice/client/lib/src/observatory/isolate_manager.dart

index e598e40aff45283258ffda2722577fc2b9ef06c8..cc53a7b5377b34412186d45f01bddcaed537f558 100644

--- a/runtime/bin/vmservice/client/lib/src/observatory/isolate_manager.dart

+++ b/runtime/bin/vmservice/client/lib/src/observatory/isolate_manager.dart

@@ -12,7 +12,7 @@ class IsolateManager extends Observable {

@observable final Map<String, Isolate> isolates =

toObservable(new Map<String, Isolate>());

- static bool _foundIsolateInMembers(int id, List<Map> members) {

+ static bool _foundIsolateInMembers(String id, List<Map> members) {

return members.any((E) => E['id'] == id);

}

@@ -26,10 +26,6 @@ class IsolateManager extends Observable {

Isolate getIsolate(String id) {

Isolate isolate = isolates[id];

- if (isolate == null) {

- isolate = new Isolate(id, '');

- isolates[id] = isolate;

- }

return isolate;

}