Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1117)

Unified Diff: runtime/bin/vmservice/client/deployed/web/index.html

Issue 135843006: Improve Code object support in service and observatory (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/deployed/web/index.html
diff --git a/runtime/bin/vmservice/client/deployed/web/index.html b/runtime/bin/vmservice/client/deployed/web/index.html
index 5ea58950dae243cca6745704e7f4252f9f6d299f..264db6bd3fef0ba04c978dad911dd3d01aa11565 100644
--- a/runtime/bin/vmservice/client/deployed/web/index.html
+++ b/runtime/bin/vmservice/client/deployed/web/index.html
@@ -171,18 +171,11 @@
</polymer-element><polymer-element name="disassembly-entry" extends="observatory-element">
<template>
<div class="row">
- <template if="{{ instruction['type'] == 'DisassembledInstructionComment' }}">
<div class="col-md-2"></div>
- <div class="col-md-2"></div>
- <div class="col-md-4"><code>{{ instruction['comment'] }}</code></div>
- </template>
- <template if="{{ instruction['type'] == 'DisassembledInstruction' }}">
- <div class="col-md-2"></div>
- <div class="col-md-2">{{ instruction['pc'] }}</div>
+ <div class="col-md-2">{{ instruction.formattedAddress() }}</div>
<div class="col-md-4">
- <code>{{ instruction['hex'] }} {{ instruction['human'] }}</code>
+ <code>{{ instruction.machine }} {{ instruction.human }}</code>
</div>
- </template>
</div>
</template>
@@ -192,7 +185,7 @@
<div class="col-md-8 col-md-offset-2">
<div class="{{ cssPanelClass }}">
<div class="panel-heading">
- <function-ref app="{{ app }}" ref="{{ code['function'] }}"></function-ref>
+ <function-ref app="{{ app }}" ref="{{ code.functionRef }}"></function-ref>
</div>
<div class="panel-body">
<div class="row">
@@ -200,7 +193,7 @@
<div class="col-md-2"><strong>Address</strong></div>
<div><strong>Instruction</strong></div>
</div>
- <template repeat="{{ instruction in code['disassembly'] }}">
+ <template repeat="{{ instruction in code.instructions }}">
<disassembly-entry instruction="{{ instruction }}">
</disassembly-entry>
</template>
@@ -586,7 +579,7 @@
<function-view app="{{ app }}" function="{{ message }}"></function-view>
</template>
<template if="{{ messageType == 'Code' }}">
- <code-view app="{{ app }}" code="{{ message }}"></code-view>
+ <code-view app="{{ app }}" code="{{ message['code'] }}"></code-view>
</template>
<template if="{{ messageType == 'Script' }}">
<script-view app="{{ app }}" script="{{ message }}"></script-view>

Powered by Google App Engine
This is Rietveld 408576698