Issue 135843004: Flag-flip of app-list-voice-search (2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 135843004: Flag-flip of app-list-voice-search (2) (Closed)

Created:
6 years, 11 months ago by Jun Mukai

Modified:
6 years, 11 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, benwells

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Flag-flip of app-list-voice-search (2) The 1st patch was reverted because it appears on all platforms accidentally. This is on by default only in ChromeOS. BUG=333914 TBR=xiyuan@chromium.org TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245345

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -17 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/app_list/start_page_service.cc	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	ui/app_list/app_list_switches.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	ui/app_list/app_list_switches.cc	View	1 chunk	+11 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/135843004/1

6 years, 11 months ago (2014-01-16 18:32:34 UTC) #1

Message was sent while issue was closed.

Change committed as 245345