src/objects.cc - Issue 1358423002: [es6] Introduce spec compliant IsConstructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 1358423002: [es6] Introduce spec compliant IsConstructor. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix stupid fuzzer failure (constructor bit set on sloppy/strict arguments). Fix MIPS/MIPS64 typos, … Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index d5cbcda37e2f003a72ba76b2bed9dc6b5986e487..3e88c961eef0756bc54e58bbae3d0a2076beebd2 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -10719,7 +10719,7 @@ void JSFunction::SetInstancePrototype(Handle<JSFunction> function,

void JSFunction::SetPrototype(Handle<JSFunction> function,

Handle<Object> value) {

- DCHECK(function->should_have_prototype());

+ DCHECK(function->IsConstructor());

Handle<Object> construct_prototype = value;

// If the value is not a JSReceiver, store the value in the map's

« no previous file with comments | « src/objects.h ('k') | src/objects-debug.cc » ('j') | no next file with comments »